feat: Added release channel as optional sign parameter#1250
Conversation
kumar303
left a comment
kumar303
left a comment
There was a problem hiding this comment.
This looks pretty good but it needs some test coverage so we don't accidentally break our integration with sign-addon.
I would suggest making a copy of this test and then remove all the assertions and add one more to check that channel gets passed through to signAddon().
|
I added the test for channel parameter passing to the signer. I hope this is ok. |
|
It might be worth to consider merging this in the light of the soon to be deactivated beta channel on AMO, since it helps with getting signed xpis for the selfhosted channel on the commandline without having to use the AMO UI. |
rpl
changed the title
kumar303
left a comment
kumar303
left a comment
There was a problem hiding this comment.
@sneakypete81 yeah, the test could use some clean-up. Other than that, we would need an issue on file so we can give it the needs: docs label.
My web-ext domain knowledge is a bit rusty these days, so @rpl should probably take a look, too.
| timeout: stubs.signingConfig.timeout, | ||
| version: stubs.preValidatedManifest.version, | ||
| xpiPath: stubs.buildResult.extensionPath, | ||
| channel: 'unlisted', |
There was a problem hiding this comment.
This is the only important part so you can remove all other parameter assertions.
How about #877? |
|
Yep, that looks like the same issue. I updated the description so it will close that one. Thanks. |
|
This patch was amended and merged via #1400 |
5 participants
Fixes #877
Added release channel as optional sign parameter.
To be effective, this requires a version of the sign-addon module patched with PR #249 or #250.