Skip to content

chore: promote dev → main — Review PR shorthand doc update#136

Merged
mpaulosky merged 6 commits into
mainfrom
squad/133-promote-to-main
Apr 24, 2026
Merged

chore: promote dev → main — Review PR shorthand doc update#136
mpaulosky merged 6 commits into
mainfrom
squad/133-promote-to-main

Conversation

@mpaulosky

Copy link
Copy Markdown
Owner

Promotes the Squad Commands shorthand addition to main.

Changes

Checklist

  • CI green on dev
  • Docs-only change

Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com

mpaulosky and others added 6 commits April 24, 2026 08:45
Blog posts, README, and docs/index.html updated for v1.2.0. Reviewed and approved by Aragorn.
Fixes 3 review blockers identified in PR #126 review:

- docs/index.html: npm run css:watch → npm run tw:watch (matches root package.json)
- README.md + kickoff blog post: Aspire 13.2.2 → 13.2.3 (matches Directory.Packages.props)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
## Summary

Adds `workflow_dispatch` trigger to `squad-mark-released.yml` so the
Done → Released project board migration can be run manually.

## Problem

When v1.2.0 was published, `squad-mark-released.yml` did not fire —
likely because the release event and workflow landing on `main` had a
timing race. With no manual trigger, the only recovery path was direct
GraphQL mutations.

## Changes

- Add `workflow_dispatch: {}` trigger
- Update job `if` condition to always run on manual dispatch (skip the
pre-release/draft guard for `workflow_dispatch` events)
- Use `context.payload.release?.tag_name ?? 'manual dispatch'` to
prevent null-ref in the summary notice

## Testing

After merge to `dev` → `main`, the workflow will appear under **Actions
→ Squad Mark Released → Run workflow** for manual recovery use.

---
> ⚠️ This PR should be fast-tracked to `main` so `dev` and `main` stay
in sync.

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Boromir <boromir@squad.dev>
Closes #130

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Closes #133

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep dev shorthand form (Review PR #{N}) over main's older form.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 24, 2026 17:47
@github-actions

Copy link
Copy Markdown
Contributor

🏗️ PR Added to Squad Triage Queue

This PR has been labeled with squad and added to the triage queue.

Next steps:

  • The squad Lead will review and assign to an appropriate team member
  • A squad:member label will be added after triage

If you know which squad member should handle this, you can add the appropriate squad:member label yourself.

@github-actions github-actions Bot added the squad Squad triage inbox — Lead will assign to a member label Apr 24, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Promotes a docs-only update from dev to main that adds a shorthand PR review command and updates the Squad Commands reference accordingly.

Changes:

  • Add Review PR #{N} as a documented shorthand for engaging Aragorn as lead reviewer.
  • Add an Aragorn review-sequence callout (Critical Rules #7 & #8).
  • Update “Common Sequences” to use the new shorthand.

Comment thread docs/SQUAD-COMMANDS.md
→ yes
→ PR opens dev → main
Aragorn review PR #{N}
Review PR #{N}

Copilot AI Apr 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "Release a sprint to main" sequence, the flow uses leading "→" markers on each step except the new Review PR #{N} line. Add the arrow marker (or otherwise align formatting) so the step is clearly part of the flow.

Suggested change
Review PR #{N}
Review PR #{N}

Copilot uses AI. Check for mistakes.
Comment thread docs/SQUAD-COMMANDS.md
Comment on lines 136 to 140
### Ship a feature PR
```
Aragorn review PR #{N} ← CI check + Copilot review + verdict + merge
Review PR #{N} ← CI check + Copilot review + verdict + merge
clean up ← remove merged branches, sync repos
```

Copilot AI Apr 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After introducing the Review PR #{N} shorthand and updating the "Common Sequences" examples to use it, the earlier "Sprint & Release Commands" example flow still shows → Aragorn review PR #{N} (lines 87–93). Updating that earlier example too would keep the doc consistent and avoid users copying the older command.

Copilot uses AI. Check for mistakes.
Comment thread docs/SQUAD-COMMANDS.md
Comment on lines +48 to +49
> CI pass → read Copilot review (fix bugs/security; style is discretionary) → parallel domain review → fix cycle if rejected → approve → squash merge → sync local.
> Before any push: full test suite must pass locally — CI is never the first place failures are found.

Copilot AI Apr 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new Aragorn review callout reads a bit ungrammatically as "CI pass" and is a long run-on sequence. Consider rephrasing (e.g., "CI passes" / "CI is green") and splitting the sequence into multiple lines or a numbered list to improve readability and reduce ambiguity.

Suggested change
> CI pass → read Copilot review (fix bugs/security; style is discretionary) → parallel domain review → fix cycle if rejected → approve → squash merge → sync local.
> Before any push: full test suite must pass locally — CI is never the first place failures are found.
> 1. Wait until CI passes.
> 2. Read the Copilot review and fix bugs or security issues; style feedback is discretionary.
> 3. Perform the parallel domain review.
> 4. If the PR is rejected, complete the fix cycle before continuing.
> 5. Approve the PR.
> 6. Squash merge it.
> 7. Sync local branches.
>
> Before any push: the full test suite must pass locally — CI is never the first place failures are found.

Copilot uses AI. Check for mistakes.
@github-actions

Copy link
Copy Markdown
Contributor

Test Results Summary

206 tests  ±0   206 ✅ ±0   14s ⏱️ ±0s
  5 suites ±0     0 💤 ±0 
  5 files   ±0     0 ❌ ±0 

Results for commit 4884548. ± Comparison against base commit bacf9b5.

@mpaulosky
mpaulosky merged commit 9b851e6 into main Apr 24, 2026
19 checks passed
@mpaulosky
mpaulosky deleted the squad/133-promote-to-main branch April 24, 2026 17:51
@codecov

codecov Bot commented Apr 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.93%. Comparing base (bacf9b5) to head (4884548).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   76.93%   76.93%           
=======================================
  Files          43       43           
  Lines         672      672           
  Branches      111      111           
=======================================
  Hits          517      517           
  Misses        105      105           
  Partials       50       50           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

squad Squad triage inbox — Lead will assign to a member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants