chore: promote dev → main — Review PR shorthand doc update#136
Conversation
Blog posts, README, and docs/index.html updated for v1.2.0. Reviewed and approved by Aragorn.
Fixes 3 review blockers identified in PR #126 review: - docs/index.html: npm run css:watch → npm run tw:watch (matches root package.json) - README.md + kickoff blog post: Aspire 13.2.2 → 13.2.3 (matches Directory.Packages.props) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
## Summary
Adds `workflow_dispatch` trigger to `squad-mark-released.yml` so the
Done → Released project board migration can be run manually.
## Problem
When v1.2.0 was published, `squad-mark-released.yml` did not fire —
likely because the release event and workflow landing on `main` had a
timing race. With no manual trigger, the only recovery path was direct
GraphQL mutations.
## Changes
- Add `workflow_dispatch: {}` trigger
- Update job `if` condition to always run on manual dispatch (skip the
pre-release/draft guard for `workflow_dispatch` events)
- Use `context.payload.release?.tag_name ?? 'manual dispatch'` to
prevent null-ref in the summary notice
## Testing
After merge to `dev` → `main`, the workflow will appear under **Actions
→ Squad Mark Released → Run workflow** for manual recovery use.
---
> ⚠️ This PR should be fast-tracked to `main` so `dev` and `main` stay
in sync.
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Boromir <boromir@squad.dev>
Closes #130 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Closes #133 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Keep dev shorthand form (Review PR #{N}) over main's older form.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
🏗️ PR Added to Squad Triage QueueThis PR has been labeled with Next steps:
|
| → yes | ||
| → PR opens dev → main | ||
| Aragorn review PR #{N} | ||
| Review PR #{N} |
There was a problem hiding this comment.
In the "Release a sprint to main" sequence, the flow uses leading "→" markers on each step except the new Review PR #{N} line. Add the arrow marker (or otherwise align formatting) so the step is clearly part of the flow.
| Review PR #{N} | |
| → Review PR #{N} |
| ### Ship a feature PR | ||
| ``` | ||
| Aragorn review PR #{N} ← CI check + Copilot review + verdict + merge | ||
| Review PR #{N} ← CI check + Copilot review + verdict + merge | ||
| clean up ← remove merged branches, sync repos | ||
| ``` |
There was a problem hiding this comment.
After introducing the Review PR #{N} shorthand and updating the "Common Sequences" examples to use it, the earlier "Sprint & Release Commands" example flow still shows → Aragorn review PR #{N} (lines 87–93). Updating that earlier example too would keep the doc consistent and avoid users copying the older command.
| > CI pass → read Copilot review (fix bugs/security; style is discretionary) → parallel domain review → fix cycle if rejected → approve → squash merge → sync local. | ||
| > Before any push: full test suite must pass locally — CI is never the first place failures are found. |
There was a problem hiding this comment.
The new Aragorn review callout reads a bit ungrammatically as "CI pass" and is a long run-on sequence. Consider rephrasing (e.g., "CI passes" / "CI is green") and splitting the sequence into multiple lines or a numbered list to improve readability and reduce ambiguity.
| > CI pass → read Copilot review (fix bugs/security; style is discretionary) → parallel domain review → fix cycle if rejected → approve → squash merge → sync local. | |
| > Before any push: full test suite must pass locally — CI is never the first place failures are found. | |
| > 1. Wait until CI passes. | |
| > 2. Read the Copilot review and fix bugs or security issues; style feedback is discretionary. | |
| > 3. Perform the parallel domain review. | |
| > 4. If the PR is rejected, complete the fix cycle before continuing. | |
| > 5. Approve the PR. | |
| > 6. Squash merge it. | |
| > 7. Sync local branches. | |
| > | |
| > Before any push: the full test suite must pass locally — CI is never the first place failures are found. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #136 +/- ##
=======================================
Coverage 76.93% 76.93%
=======================================
Files 43 43
Lines 672 672
Branches 111 111
=======================================
Hits 517 517
Misses 105 105
Partials 50 50 🚀 New features to boost your workflow:
|
Promotes the Squad Commands shorthand addition to main.
Changes
Review PR #{N}shorthand (merged via PR docs: add Review PR shorthand command to Squad Commands (#133) #134, closes docs: add Review PR shorthand command to Squad Commands reference #133)Checklist
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com