Skip to content

chore: promote dev → main — Review PR shorthand doc update #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mpaulosky merged 6 commits into from
Apr 24, 2026
Merged

chore: promote dev → main — Review PR shorthand doc update #136

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c75a283
docs: post-release documentation update for v1.2.0 (#125)
mpaulosky Apr 24, 2026
6352f91
fix(docs): address Aragorn review blockers — PR #126
mpaulosky Apr 24, 2026
566c642
ci: add workflow_dispatch to squad-mark-released.yml
mpaulosky Apr 24, 2026
b79a12e
docs: add Squad Commands quick reference guide (#130)
mpaulosky Apr 24, 2026
475185e
docs: add Review PR shorthand command to Squad Commands (#133)
mpaulosky Apr 24, 2026
4884548
chore: merge main into dev — resolve SQUAD-COMMANDS shorthand conflicts
Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions docs/SQUAD-COMMANDS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,12 +40,18 @@ Bilbo write a release blog post for v1.2.0

| Command | What it does |
|---------|-------------|
| `Review PR #{N}` | Shorthand — engages Aragorn as lead reviewer. Equivalent to `Aragorn review PR #{N}`. |
| `{Member} review PR #{N}` | Member follows Critical Rule #7: waits for CI → reads Copilot review → posts verdict → merges if approved. |
| `{Member} wait for the gh review on PR #{N}` | Member watches CI and the GitHub Copilot automated review before posting their own verdict. |

> **Aragorn's review sequence (Critical Rules #7 & #8):**
> CI pass → read Copilot review (fix bugs/security; style is discretionary) → parallel domain review → fix cycle if rejected → approve → squash merge → sync local.
> Before any push: full test suite must pass locally — CI is never the first place failures are found.
Comment on lines +48 to +49

Copilot AI Apr 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new Aragorn review callout reads a bit ungrammatically as "CI pass" and is a long run-on sequence. Consider rephrasing (e.g., "CI passes" / "CI is green") and splitting the sequence into multiple lines or a numbered list to improve readability and reduce ambiguity.

Suggested change
> CI pass → read Copilot review (fix bugs/security; style is discretionary) → parallel domain review → fix cycle if rejected → approve → squash merge → sync local.
> Before any push: full test suite must pass locally — CI is never the first place failures are found.
> 1. Wait until CI passes.
> 2. Read the Copilot review and fix bugs or security issues; style feedback is discretionary.
> 3. Perform the parallel domain review.
> 4. If the PR is rejected, complete the fix cycle before continuing.
> 5. Approve the PR.
> 6. Squash merge it.
> 7. Sync local branches.
>
> Before any push: the full test suite must pass locally — CI is never the first place failures are found.

Copilot uses AI. Check for mistakes.

**Examples:**

```
Review PR #131
Aragorn review PR #128
Aragorn wait for the gh review on PR #126 the review
```
Expand Down Expand Up @@ -129,7 +135,7 @@ fan squad begin work

### Ship a feature PR
```
Aragorn review PR #{N} ← CI check + Copilot review + verdict + merge
Review PR #{N} ← CI check + Copilot review + verdict + merge
clean up ← remove merged branches, sync repos
```
Comment on lines 136 to 140

Copilot AI Apr 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After introducing the Review PR #{N} shorthand and updating the "Common Sequences" examples to use it, the earlier "Sprint & Release Commands" example flow still shows → Aragorn review PR #{N} (lines 87–93). Updating that earlier example too would keep the doc consistent and avoid users copying the older command.

Copilot uses AI. Check for mistakes.

Expand All @@ -138,7 +144,7 @@ clean up ← remove merged branches, sync repos
Is Sprint N a release candidate?
→ yes
→ PR opens dev → main
Aragorn review PR #{N}
Review PR #{N}

Copilot AI Apr 24, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the "Release a sprint to main" sequence, the flow uses leading "→" markers on each step except the new Review PR #{N} line. Add the arrow marker (or otherwise align formatting) so the step is clearly part of the flow.

Suggested change
Review PR #{N}
→ Review PR #{N}

Copilot uses AI. Check for mistakes.
→ approved and merged
```

Expand Down
Loading