Make SerializerBuilder<TObject>.GetTargetMembers() stricter (fix #28)#30
Closed
takeshik wants to merge 1 commit intomsgpack:masterfrom
takeshik:feature/make-get-target-stricter
Closed
Make SerializerBuilder<TObject>.GetTargetMembers() stricter (fix #28)#30takeshik wants to merge 1 commit intomsgpack:masterfrom takeshik:feature/make-get-target-stricter
takeshik wants to merge 1 commit intomsgpack:masterfrom
takeshik:feature/make-get-target-stricter
Conversation
Remove non-accessible members from the target: * Properties which does not have either public getter or setter. * Fields which is initonly.
Member
|
Thank you for your great work, but this patch introduces new issue that read-only collection typed members are not serialized properly. So, I reject your request. Thanks anyway. |
yfakariya
added a commit
that referenced
this pull request
May 24, 2014
yfakariya
added a commit
that referenced
this pull request
May 24, 2014
Signed-off-by: yfakariya <yfakariya@gmail.com>
Contributor
Author
|
Thanks for your consideration. I'll submit again a new PR when I solved problems that you mentioned. And, I'll check and write tests from next time 😉 arigato gozaimashita! |
Contributor
Author
|
(forgot to close) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
initonly.Concerns
If there are problems, please reject it. This modification may be optimistic.