Make SerializerBuilder<TObject>.GetTargetMembers() stricter (fix #28) (+ trivial fixes)#32
Merged
yfakariya merged 3 commits intomsgpack:0.5from Jun 28, 2014
takeshik:issue-28
Merged
Make SerializerBuilder<TObject>.GetTargetMembers() stricter (fix #28) (+ trivial fixes)#32yfakariya merged 3 commits intomsgpack:0.5from takeshik:issue-28
yfakariya merged 3 commits intomsgpack:0.5from
takeshik:issue-28
Conversation
added 3 commits
June 23, 2014 21:15
Remove non-accessible members from the target: * properties which has no public setter, or * fields which is initonly, * moreover, it is not a addable collection nor dictionary.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Re-submit of #30.
SerializerDebugging.ResetDependentAssemblies()method: it doesn't writes out newline before the EOF. This makes invalid paths (perhaps) next test run. This PR fixes it..nuget/of this repo (or branch) is old, it fails to restore packages. This PR renew them.Notes
CheckTargetEligibility, might be not good. Please rename it if you need.If there are any trouble, please tell me.