Text Analytics API review tool feedback#2
Merged
Conversation
samvaity
force-pushed
the
text-analytics
branch
from
November 25, 2019 22:24
3edcdd1 to
7f13f5b
Compare
samvaity
commented
Nov 25, 2019
| TextSentimentResult setTextSentiment(TextSentiment textSentiment) { | ||
| this.textSentiment = textSentiment; | ||
| return this; | ||
| public IterableStream<TextSentiment> getTextSentiments() { |
Collaborator
Author
There was a problem hiding this comment.
@mssfang have kept this as getTextSentiments rather that getSentenceSentiments as I think with the sentence we are introducing another keyword to the user. What do you think?
Owner
There was a problem hiding this comment.
If we keep getTextSentiments, we are assuming user know the the getTextSentiment is getting the sentence sentiments
Owner
There was a problem hiding this comment.
I think the sentence sentiment is already introduced by the service team. So i think it should be fine to change to SentenceSentiment. It gives the user the intuitive sense the List of TextSentiment is a list of Sentence Sentiment.
mssfang
approved these changes
Nov 25, 2019
mssfang
approved these changes
Nov 25, 2019
mssfang
pushed a commit
that referenced
this pull request
Jan 27, 2020
mssfang
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Documentation changes * Removing unused KeyVaultCertificate class * Add sample java code Co-authored-by: Rujun Chen <rujche@microsoft.com>
mssfang
pushed a commit
that referenced
this pull request
Mar 30, 2023
* health insights sdk for java * rename country to countryOrRegion * update product name to azure-health-insights * update cspell with missing words * update root pom.xml and version_client.txt * update dependency versions * update dependency versions (#2) * skip jacoco * fix spell checks * Asaflevi/feature/healthinsights sdk for java (#3) * update dependency versions * skip jacoco * fix spell checks * skip jacoco * linting * remove redundant plugins * remove test.yaml files * remove redundant package.json file * fix sampes and readmes * spell * fix linting * fix sample repository reference * remove duplicate dependency (mockito) * alignment (readme) * fix readme title * setPlaybackSyncPollerPollInterval * update serviceversion class (emitter 0.5.1) * remove impressions png
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.