feat: Overview for new ui. - #2536
Closed
yanguoyu wants to merge 6 commits into
Closed
Conversation
yanguoyu
commented
Nov 28, 2022
yanguoyu
commented
Contributor
- Overview of light
- Overview of dark
Contributor
Author
|
I set this PR to draft because I will split the pr into more pr for handy review. And the subtasks I have updated in Magickbase/neuron-public-issues#70 (comment) |
yanguoyu
force-pushed
the
feat-new-ui-overview
branch
from
March 9, 2023 10:37
b7b836d to
d31240f
Compare
alexsupa597
approved these changes
Mar 22, 2023
| ) | ||
| } | ||
|
|
||
| const getNetworkTypeLable = (type: 'ckb' | 'ckb_testnet' | 'ckb_dev' | string) => { |
There was a problem hiding this comment.
This type of constraint is a little odd.
| } | ||
| } | ||
| .confirmText { | ||
| color: #999; |
There was a problem hiding this comment.
Do we need to consider the color of different themes?
Contributor
Author
| type: AppActions.SetPageNotice, | ||
| payload: { i18nKey, status }, | ||
| }) | ||
| timer = setTimeout(() => { |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.