Add page container component for all page. - #2608
Merged
Keith-CY merged 1 commit intoMar 24, 2023
Merged
Conversation
3 tasks
Contributor
The arrow should point down by default and point up on hovering |
Contributor
Author
Fixed.
|
Contributor
Author
|
@JeffreyMa597 @devchenyan Please have a review. |
devchenyan
approved these changes
Mar 23, 2023
Comment on lines
+270
to
+275
| handle('set-theme', async (_, theme: 'system' | 'light' | 'dark') => { | ||
| SettingsService.getInstance().themeSource = theme | ||
| return { | ||
| status: ResponseCode.Success | ||
| } | ||
| }) |
Contributor
There was a problem hiding this comment.
enum ThemeEnum { SYSTEM = 'system', LIGHT = 'light', DARK = 'dark' }
Contributor
Author
There was a problem hiding this comment.
Are there any differences between these? Or why this is better?
fix: Sync text color. fix: Fix icon direction. fix: Set default value
yanguoyu
force-pushed
the
feat-new-ui-page-container
branch
from
March 24, 2023 05:56
3de822f to
ff4f352
Compare
Keith-CY
approved these changes
Mar 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Only need to attention to the page head. Others in the overview will open another pr.
pageContainer.mov