Fix Crash When Write Activities From Random Any File#12583
Merged
Conversation
alperozturk96
force-pushed
the
bugfix/crash-on-file-detail-activies
branch
2 times, most recently
from
March 11, 2024 11:48
96b7c05 to
861ca60
Compare
ZetaTom
reviewed
Mar 11, 2024
alperozturk96
force-pushed
the
bugfix/crash-on-file-detail-activies
branch
3 times, most recently
from
March 15, 2024 13:59
794c123 to
99b122f
Compare
Signed-off-by: alperozturk <alper_ozturk@proton.me>
Signed-off-by: alperozturk <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
bugfix/crash-on-file-detail-activies
branch
from
March 18, 2024 12:14
99b122f to
dae166f
Compare
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/12583.apk |
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/12583-Screenshot-blue-Light-12-58 |
ZetaTom
approved these changes
Mar 18, 2024
ZetaTom
left a comment
ZetaTom
left a comment
Collaborator
There was a problem hiding this comment.
In my tests, everything worked as expected.
If the server is unavailable and one tries to comment on a file/directory, it doesn't work, which is expected. But the button still shows the ripple effect and the user is left without any feedback. I think we should address the lack of feedback at a later point in time.
AndyScherzinger
disabled auto-merge
March 18, 2024 14:49
delete-merged-branch
Bot
deleted the
bugfix/crash-on-file-detail-activies
branch
March 18, 2024 14:49
4 tasks
This was referenced Jul 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Crash was happening due to asynchronous code execution. In some rare scenarios ownCloud client was null. In this PR I check thread completion and ownCloud client nullability.