Skip to content

Fix Crash When Write Activities From Random Any File #12583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AndyScherzinger merged 3 commits into from
Mar 18, 2024
Merged

Fix Crash When Write Activities From Random Any File #12583

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5834de8
Fix crash
alperozturk96 Feb 21, 2024
33dcd22
Replace print function with Log_OC.d
alperozturk96 Feb 21, 2024
dae166f
Fix condition
alperozturk96 Mar 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion app/src/main/java/com/owncloud/android/ui/fragment/FileDetailActivitiesFragment.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,7 @@ public class FileDetailActivitiesFragment extends Fragment implements

private int lastGiven;
private boolean isLoadingActivities;
private boolean isDataFetched = false;

private boolean restoreFileVersionSupported;
private FileOperationsHelper operationsHelper;
Expand Down Expand Up @@ -198,7 +199,7 @@ public void submitComment() {

String trimmedComment = commentField.toString().trim();

if (trimmedComment.length() > 0) {
if (trimmedComment.length() > 0 && ownCloudClient != null && isDataFetched) {
new SubmitCommentTask(trimmedComment, file.getLocalId(), callback, ownCloudClient).execute();
}
}
Expand Down Expand Up @@ -340,6 +341,8 @@ private void fetchAndSetData(int lastGiven) {
populateList(activitiesAndVersions, lastGiven == -1);
}
});

isDataFetched = true;
} else {
Log_OC.d(TAG, result.getLogMessage());
// show error
Expand All @@ -354,10 +357,13 @@ private void fetchAndSetData(int lastGiven) {
isLoadingActivities = false;
}
});

isDataFetched = false;
}

hideRefreshLayoutLoader(activity);
} catch (ClientFactory.CreationException e) {
isDataFetched = false;
Log_OC.e(TAG, "Error fetching file details activities", e);
}
});
Expand Down