AutoUpload improvements

[mario]

This should fix two issues:

• resolves Auto Upload: uploads 0b files #1295
• And one where uploads are not started on boot (still strange, but this is a workaround which might help).

Wasn't tested since I can't reproduce, but I know @tobiasKaminsky can on his phone, so please do.

[mario]

Oh and it might help with #1450

[mario]

@AndyScherzinger we talked about merges/rebases without asking :P

[AndyScherzinger]

we talked about merges/rebases without asking :P

Thought that is about rebase, well than I'll also stop doing it for merged :)

[AndyScherzinger]

@mario test is negative :( The actual state is broken... Tested with "only during charging", taking 3 pictures

This PR:
Queue (0B!)

"Uploaded" (55B!) --> no upload happened, nothing on the server, no log entries, no file, no activity written

Same done for master:

Issue (of course) on the master is that the timestamp is the upload time, not the file created/modified.

[AndyScherzinger]

@mario btw I fixed some lint issues to make the drone build happy...

[mario]

@AndyScherzinger thanks, will take a look.

[AndyScherzinger]

Sweet!sorry for not having better news from testing :(

[mario]

@AndyScherzinger if you can test once more (did an update) for both internal and SD card uploads, that would be sweet. I'll do more thorough testing once I'm back at my desk.

[AndyScherzinger]

Sorry to disappoint you but the behavior described before remains the same except that the very first image waiting for upload shows the correct size in the queue, anything else is 0B and after "upload everything is 55B (displayed) while still none gets uploaded.

[AndyScherzinger]

Now size gets hidden for queued/failed uploads 👍
Unfortunately all uploads simply fail with http status -1 and I don't see any further infos in the logcat :/

[mario]

o.O SD card or internal storage?

I tested this on a few phones, and it worked here :-/

[AndyScherzinger]

internal storage

...not saying it has something todo with the device since I has re-login issues with the server yesterday but they are gone today ?! So it might work just fine. Hoping that @tobiasKaminsky can have another look so we are sure it is just my server...

[AndyScherzinger]

@mario tested it again using @tobiasKaminsky's server instead of mine and I get the same error (fresh installation of the app on the phone - OP3T):

09-04 17:52:40.119 17845-20345/com.nextcloud.client E/UploadFileOperation: Upload of /storage/emulated/0/DCIM/Camera/IMG_20170904_175219.jpg to /InstantUpload/Camera/IMG_20170904_175219.jpg: Operation finished with HTTP status code -1 (fail)

[AndyScherzinger]

@mario just re-tested with master and there the files simply upload, no issues...

[mario]

But not for all use-cases :) Pushed improvements, can you try?

…

On Mon, Sep 4, 2017 at 6:01 PM, Andy Scherzinger ***@***.***> wrote: @mario <https://github.com/mario> just re-tested with master and there the files simply upload, no issues... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1468 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAWsl7DGaR9VIeiAZE06dTWyuQh-hO1ks5sfB7UgaJpZM4PIoaM> .

[AndyScherzinger]

unfortunately I'm afk again for today :/

[enoch85]

If you can send me a test account with this PR included to daniel at techandme dot se I can test this PR with Huwaei P10 which produces the log spamming.

[mario]

@enoch85 you mean apk? :) Can do it tomorrow, sure...

[enoch85]

@mario Yeah, even better actually. :)

[tobiasKaminsky]

I tried it with my emulator, android 7 as a very first test:
The file is recognized and somehow "uploaded".
For a very short moment it is also visible in the correct folder:

But the file is not on server (also checked on filesystem).

However it is shown as correctly uploaded:

In Logcat I did not see any error. Only this related:

09-05 08:17:38.522 7175-7588/com.nextcloud.client D/UploadsStorageManager: updateDataseUploadResult uploadResult: com.owncloud.android.lib.common.operations.RemoteOperationResult@6aa377c upload: com.owncloud.android.operations.UploadFileOperation@9499805
09-05 08:17:38.526 7175-7199/com.nextcloud.client D/Thumbnail: URI: https://10.0.2.2/nc/index.php/apps/files/api/v1/thumbnail/256/256/SofortUpload/Camera/2017/09/IMG_20170905_081736.jpg
09-05 08:17:38.533 7175-7199/com.nextcloud.client D/OwnCloudClient #4: REQUEST GET /nc/index.php/apps/files/api/v1/thumbnail/256/256/SofortUpload/Camera/2017/09/IMG_20170905_081736.jpg
09-05 08:17:38.533 7175-7588/com.nextcloud.client V/UploadsStorageManager: Updating /storage/emulated/0/DCIM/Camera/IMG_20170905_081736.jpg with status:UPLOAD_SUCCEEDED and result:UPLOADED (old:/storage/emulated/0/DCIM/Camera/IMG_20170905_081736.jpg status:UPLOAD_IN_PROGRESS result:-1)
09-05 08:17:38.535 7175-7588/com.nextcloud.client V/UploadsStorageManager: Updating /storage/emulated/0/DCIM/Camera/IMG_20170905_081736.jpg with status=UPLOAD_SUCCEEDED
09-05 08:17:38.541 7175-7588/com.nextcloud.client D/UploadsStorageManager: updateUpload returns with: 1 for file: /storage/emulated/0/DCIM/Camera/IMG_20170905_081736.jpg

[mario]

What emulator, so i can see if I can replicate?

…

On Tue, 5 Sep 2017 at 08:23, Tobias Kaminsky ***@***.***> wrote: I tried it with my emulator, android 7 as a very first test: The file is recognized and somehow "uploaded". For a very short moment it is also visible in the correct folder: [image: 2017-09-05-081754] <https://user-images.githubusercontent.com/5836855/30047779-3263d448-9213-11e7-9a0e-5c68e881103e.png> But the file is not on server (also checked on filesystem). However it is shown as correctly uploaded: [image: 2017-09-05-082230] <https://user-images.githubusercontent.com/5836855/30047816-6011ce86-9213-11e7-902f-578479acb214.png> In Logcat I did not see any error. Only this related: 09-05 08:17:38.522 7175-7588/com.nextcloud.client D/UploadsStorageManager: updateDataseUploadResult uploadResult: ***@***.*** upload: ***@***.*** 09-05 08:17:38.526 7175-7199/com.nextcloud.client D/Thumbnail: URI: https://10.0.2.2/nc/index.php/apps/files/api/v1/thumbnail/256/256/SofortUpload/Camera/2017/09/IMG_20170905_081736.jpg 09-05 08:17:38.533 7175-7199/com.nextcloud.client D/OwnCloudClient #4: REQUEST GET /nc/index.php/apps/files/api/v1/thumbnail/256/256/SofortUpload/Camera/2017/09/IMG_20170905_081736.jpg 09-05 08:17:38.533 7175-7588/com.nextcloud.client V/UploadsStorageManager: Updating /storage/emulated/0/DCIM/Camera/IMG_20170905_081736.jpg with status:UPLOAD_SUCCEEDED and result:UPLOADED (old:/storage/emulated/0/DCIM/Camera/IMG_20170905_081736.jpg status:UPLOAD_IN_PROGRESS result:-1) 09-05 08:17:38.535 7175-7588/com.nextcloud.client V/UploadsStorageManager: Updating /storage/emulated/0/DCIM/Camera/IMG_20170905_081736.jpg with status=UPLOAD_SUCCEEDED 09-05 08:17:38.541 7175-7588/com.nextcloud.client D/UploadsStorageManager: updateUpload returns with: 1 for file: /storage/emulated/0/DCIM/Camera/IMG_20170905_081736.jpg — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1468 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAWsi7ze9dSLU1byIG9t6f97pMLZWHgks5sfOjggaJpZM4PIoaM> .

[tobiasKaminsky]

API 24

[mario]

Ok. Never seen this behaviour

…

On Tue, 5 Sep 2017 at 08:35, Tobias Kaminsky ***@***.***> wrote: API 24 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1468 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAWsnUdpdTj_y4v8xZuZYNScXF7Ultsks5sfOvFgaJpZM4PIoaM> .

[mario]

@AndyScherzinger @tobiasKaminsky please try again. @tobiasKaminsky please try with the phone where you have 0 byte files :)

[AndyScherzinger]

@mario @tobiasKaminsky rebased and merged 💃