Skip to content

Release 2.0.0RC6#1473

Merged
AndyScherzinger merged 1 commit into
masterfrom
200RC6
Sep 5, 2017
Merged

Release 2.0.0RC6#1473
AndyScherzinger merged 1 commit into
masterfrom
200RC6

Conversation

@AndyScherzinger

Copy link
Copy Markdown
Member

Updated manifests for 2.0.0 RC6

cc @mario @tobiasKaminsky

@mario

mario commented Aug 31, 2017

Copy link
Copy Markdown
Contributor

👍
Sure, but we're not ready for RC6 :P

Approved with PullApprove

@AndyScherzinger

Copy link
Copy Markdown
Member Author

I know - But this way we can simply merge and tag :)

@tobiasKaminsky

Copy link
Copy Markdown
Member

About releasing schedule, my idea is that we fix today and monday outstanding bugs, like #1468 and then do a RC6 on monday afternoon?

@mario

mario commented Sep 1, 2017 via email

Copy link
Copy Markdown
Contributor

@tobiasKaminsky

Copy link
Copy Markdown
Member

We need also a new android-lib version 1.0.27 as there is at least one fix which should be in 2.0

@AndyScherzinger

Copy link
Copy Markdown
Member Author

new lib release sounds fine too 👍

@AndyScherzinger

Copy link
Copy Markdown
Member Author

@enoch85

enoch85 commented Sep 4, 2017

Copy link
Copy Markdown
Member

Guys, for how long will you "postpone" the 2.0.0 release? Seems pretty stable to me. Maybe bugs from now on can go into 2.0.1?

@AndyScherzinger

Copy link
Copy Markdown
Member Author

Afaik there are two remaining issues left open.

Login issues (relogin and also LDAP)
Log spamming with the byte size you reported

@enoch85

enoch85 commented Sep 4, 2017

Copy link
Copy Markdown
Member

Log spamming with the byte size you reported

Thought that was fixed with #1468. Not merged yet, but still. :)

@AndyScherzinger

Copy link
Copy Markdown
Member Author

That one is not yet fully checked but also isn't shipped with the dev version...

@tobiasKaminsky

Copy link
Copy Markdown
Member

Both LDAP bugs are NC10 related, so I suggest that we fix & merge #1468 and after that RC6.
All other bugs will then be postponed to 2.0.1

@AndyScherzinger

Copy link
Copy Markdown
Member Author

Sounds good to me. This PR can be merged to master at any time though ;)

@AndyScherzinger

Copy link
Copy Markdown
Member Author

rebased to check if drone turns green now :)

@mario

mario commented Sep 5, 2017

Copy link
Copy Markdown
Contributor

I'm unsure if we should postpone, but it's you two who think it's fine ... so fine :) I'll test my PR via the emulator now.

@AndyScherzinger

Copy link
Copy Markdown
Member Author

I'm unsure if we should postpone

If I understood @tobiasKaminsky then the auto upload issue would be fixed before the RC6 and afaik there is nothing else that needs fixing, right?

@mario

mario commented Sep 5, 2017

Copy link
Copy Markdown
Contributor

@AndyScherzinger well the constant login-screen-appears is an actual issue related to userID/username/whatever. Same goes for favoriting etc. I've CCed you on a few iOS tickets that experience the same issue.

RC6 fine, but yea ... I wouldn't go for 2.0.0 stable without ALL the fixes.

@AndyScherzinger

Copy link
Copy Markdown
Member Author

@mario ah, that was the issue in the iOS tickets, now I understand.
@tobiasKaminsky Well, I'd also say we need to fix the relogin issue if currently still present in the Android app since that would be quite an issue for users. :/ I had this issue on Sunday but it disappeared on Monday so I didn't have the change to debug or grab some logs...

@mario

mario commented Sep 5, 2017

Copy link
Copy Markdown
Contributor

@AndyScherzinger please merge this PR. So hard to see it here xD

@AndyScherzinger
AndyScherzinger merged commit 3bc6d8d into master Sep 5, 2017
@AndyScherzinger
AndyScherzinger deleted the 200RC6 branch September 5, 2017 07:56
@AndyScherzinger

Copy link
Copy Markdown
Member Author

DONE :)

@ all - master is now pre-configured for RC6, so whenever all RC6 relevant PRs have been merged to master it'll be all setup correctly right away (+the gplay config of course)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants