Replace media scanner on newer Android versions#5969
Conversation
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
|
Unit test failed, but no output was generated. Maybe a preliminary stage failed. |
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13722-IT |
@tobiasKaminsky that APK is incredibly slow to download (~12 KB/s) and it eventually fails. I've tried a couple times. Could you please re-upload it to another location? |
Disregard. I tried later and it downloaded fine. |
tobiasKaminsky
changed the title
|
@tobiasKaminsky Hey buddy any updates on this? do you need someone to help test? |
|
Thanks for your offer, but currently there is no need for testing, as we found the cause of the problem. |
|
I'll test as well when a new build is available. Thanks Tobias. |
Signed-off-by: Abdourahamane BOINAIDI <abdourahamane.boinaidi@infomaniak.com>
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14055-IT |
|
I download the QA and had it automatically upload and I manually uploaded files and photos and no issues. The ringtones notification are still there looks like the issue has been fixed
Sent from Outlook Mobile<https://aka.ms/blhgte>
…________________________________
From: nextcloud-android-bot <notifications@github.com>
Sent: Tuesday, May 19, 2020 6:55:54 AM
To: nextcloud/android <android@noreply.github.com>
Cc: axheli <xhelia@outlook.com>; Manual <manual@noreply.github.com>
Subject: Re: [nextcloud/android] Replace media scanner on newer Android versions (#5969)
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14055.apk
[qrcode]<https://camo.githubusercontent.com/410b7c4f2d30016c0158fff7f2a6c96d4327ae17/68747470733a2f2f7777772e6b616d696e736b792e6d652f6e632d6465762f616e64726f69642d6172746966616374732f31343035352e706e67>
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#5969 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOF3PGJPRZDI32HK5KBSQ73RSJXUVANCNFSM4MTZJ36A>.
|
|
I'm at work and only had a second to try this. I installed QA build. Manual upload was fine, no notification issues, but uploading with the option "Move file to <nc> folder" still does not keep the image in the gallery.
\-------- Original Message --------
On May 19, 2020, 08:08, axheli < ***@***.***> wrote:
I download the QA and had it automatically upload and I manually uploaded files and photos and no issues. The ringtones notification are still there looks like the issue had been fixed
Sent from Outlook Mobile<https://aka.ms/blhgte>
\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_\_
From: nextcloud-android-bot ***@***.***>
Sent: Tuesday, May 19, 2020 6:55:54 AM
To: nextcloud/android ***@***.***>
Cc: axheli ***@***.***>; Manual ***@***.***>
Subject: Re: \[nextcloud/android\] Replace media scanner on newer Android versions (\#5969)
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14055.apk
\[qrcode\]<https://camo.githubusercontent.com/410b7c4f2d30016c0158fff7f2a6c96d4327ae17/68747470733a2f2f7777772e6b616d696e736b792e6d652f6e632d6465762f616e64726f69642d6172746966616374732f31343035352e706e67>
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#5969\#issuecomment-630770270>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AOF3PGJPRZDI32HK5KBSQ73RSJXUVANCNFSM4MTZJ36A>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, [view it on GitHub][], or [unsubscribe][].![APEKEPQOCRWBLAJEL35YMUTRSJZDXA5CNFSM4MTZJ36KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEWMOCYQ.gif][]
[view it on GitHub]: #5969 (comment)
[unsubscribe]: https://github.com/notifications/unsubscribe-auth/APEKEPRZ7RCRVUOX5YRLBP3RSJZDXANCNFSM4MTZJ36A
[APEKEPQOCRWBLAJEL35YMUTRSJZDXA5CNFSM4MTZJ36KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEWMOCYQ.gif]: https://github.com/notifications/beacon/APEKEPQOCRWBLAJEL35YMUTRSJZDXA5CNFSM4MTZJ36KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEWMOCYQ.gif
|
Signed-off-by: Abdourahamane BOINAIDI <abdourahamane.boinaidi@infomaniak.com>
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14056-IT |
@elektrikfisch you can retry now, push me if the problem persists |
|
Thank you very much @sirambd for pushing it! |
Signed-off-by: Abdourahamane BOINAIDI <abdourahamane.boinaidi@infomaniak.com>
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14059-IT |
|
@sirambd Only issue i see it i have the option upload over wifi only and is keeps saying waiting on wifi and i do have it connected to wifi as well |
|
Wow @sirambd thank you very much for fixing this! |
|
@tobiasKaminsky we merge this ? :) |
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14121.apk |
Codacy389Lint
SpotBugs (new)
SpotBugs (master)
|
|
IT test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14121-IT |
|
/backport to stable-3.12 |
8 participants
Signed-off-by: tobiasKaminsky tobias@kaminsky.me
Testing
Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.
unit tests
instrumented tests
UI tests