Skip to content

New media scanner: only use with valid path#6984

Merged
tobiasKaminsky merged 1 commit into
masterfrom
newMediaScannerOnlyWithValidPath
Sep 22, 2020
Merged

New media scanner: only use with valid path#6984
tobiasKaminsky merged 1 commit into
masterfrom
newMediaScannerOnlyWithValidPath

Conversation

@tobiasKaminsky

Copy link
Copy Markdown
Member

Fix #1350

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Testing

Writing tests is very important. Please try to write some tests for your PR.
If you need help, please do not hesitate to ask in this PR for help.

unit tests
instrumented tests
UI tests

  • Tests written, or not not needed

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15902.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Codacy

393

Lint

TypemasterPR
Warnings8181
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings54
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings72
Security Warnings44
Dodgy code Warnings105
Total320

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings27
Correctness Warnings54
Internationalization Warnings9
Multithreaded correctness Warnings9
Performance Warnings72
Security Warnings44
Dodgy code Warnings105
Total320

@tobiasKaminsky
tobiasKaminsky merged commit faad388 into master Sep 22, 2020
@delete-merged-branch
delete-merged-branch Bot deleted the newMediaScannerOnlyWithValidPath branch September 22, 2020 05:40
@AndyScherzinger AndyScherzinger added this to the Nextcloud App 3.14.0 milestone Sep 22, 2020
thelittlefireman pushed a commit to thelittlefireman/android that referenced this pull request Mar 19, 2021
…ithValidPath

New media scanner: only use with valid path
Signed-off-by: thelittlefireman <thelittlefireman@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Corrupted image created during auto upload

3 participants