Show previous and successive messages of the same thread#3373
Conversation
6699d6f to
495c696
Compare
ChristophWurst
left a comment
There was a problem hiding this comment.
Looks good! Does it work? :)
almost :) its missing some front end polishing |
97306a5 to
4d25d00
Compare
4d25d00 to
af9f2ea
Compare
|
@jancborchardt right now, the threading looks like this: I did a test structure with the button, just so you could have something to test.
What I need from you is to please tell me, what's the best way to show the threading. Google has it like this: https://lh5.googleusercontent.com/GExDeK52zJZTAb-xfJJv2lHMC3CO1yNP1NkacanRStlMebBWUKqGtBytx82dgTYsWvsPHYIQc6bjVaJOkUCLdpWqwSRSr_gONGx9DSzm0kYYEueXxKlK3N4n6ygv1aWX |
1e28896 to
8b45fc6
Compare
|
@GretaD yes, doing it like Gmail sounds great! :) Also another good reference is Hey: https://www.youtube.com/watch?v=UCeYTysLyGI&t=19m45s Ideal would be if we could also collapse any quoted messages or signatures from previous messages to save space and reduce necessary scrolling, but that is maybe a further step. |
<3 thank you, i will let you know when its ready for a final review, so you dont lose time to check my fixups. |
95b4290 to
fd8a8cb
Compare
|
BUG
|
d769944 to
3534daf
Compare
Yep, this is definitely a later step as it's not a trivial problem to solve. We either have to rewrite the original message in a way that the iframe displays with collapsible quotes or we need some JS inside the iframe. Both paths are rather complex and I would like to focus on the grouping and navigation between related messages first. |
This comment has been minimized.
This comment has been minimized.
9a649b0 to
5f533d0
Compare
|
Rebased. Now this works with the latest changes from #3439, yay. |
|
Jumping between messages from the same thread works very nicely already :) |
|
Layout-wise we currently have
… if you open a message in the middle of a thread. But it should be
… like in gmail/hey. Does that make sense? not sure how well the messages newer than the current message will render when they are down below, but let's find out :) |
|
This is very basic but let's integrate and improve the design step by step 👍 |
Signed-off-by: GretaD <gretadoci@gmail.com> Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
0e3455c to
199b56d
Compare

Signed-off-by: GretaD gretadoci@gmail.com