Skip to content

Show previous and successive messages of the same thread#3373

Merged
GretaD merged 1 commit into
masterfrom
feature/threading_list
Sep 1, 2020
Merged

Show previous and successive messages of the same thread#3373
GretaD merged 1 commit into
masterfrom
feature/threading_list

Conversation

@GretaD

@GretaD GretaD commented Jul 17, 2020

Copy link
Copy Markdown
Contributor

Signed-off-by: GretaD gretadoci@gmail.com

@GretaD GretaD force-pushed the feature/threading_list branch 2 times, most recently from 6699d6f to 495c696 Compare July 17, 2020 17:56

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Does it work? :)

@GretaD

GretaD commented Jul 20, 2020

Copy link
Copy Markdown
Contributor Author

Looks good! Does it work? :)

almost :) its missing some front end polishing

@GretaD GretaD force-pushed the feature/threading_list branch 2 times, most recently from 97306a5 to 4d25d00 Compare July 20, 2020 15:31
Comment thread src/components/Message.vue Outdated
@GretaD GretaD force-pushed the feature/threading_list branch from 4d25d00 to af9f2ea Compare July 21, 2020 12:43
Comment thread lib/Controller/MessagesController.php Outdated
@GretaD

GretaD commented Jul 22, 2020

Copy link
Copy Markdown
Contributor Author

@jancborchardt right now, the threading looks like this:
thread_test

I did a test structure with the button, just so you could have something to test.

  • What is left from my side(not design related) is the link between the thread and the actual message - so when you click, it shows the whole body reply. Im poking you now, just so you have more time to think :)

What I need from you is to please tell me, what's the best way to show the threading. Google has it like this: https://lh5.googleusercontent.com/GExDeK52zJZTAb-xfJJv2lHMC3CO1yNP1NkacanRStlMebBWUKqGtBytx82dgTYsWvsPHYIQc6bjVaJOkUCLdpWqwSRSr_gONGx9DSzm0kYYEueXxKlK3N4n6ygv1aWX
I like the google idea but we have to see how we can integrate it.
Nevertheless, please tell me your idea, and if you can show it with image examples, i would be very grateful :).

@GretaD GretaD force-pushed the feature/threading_list branch from 1e28896 to 8b45fc6 Compare July 23, 2020 14:53
@jancborchardt

jancborchardt commented Jul 27, 2020

Copy link
Copy Markdown
Member

@GretaD yes, doing it like Gmail sounds great! :) Also another good reference is Hey: https://www.youtube.com/watch?v=UCeYTysLyGI&t=19m45s

Ideal would be if we could also collapse any quoted messages or signatures from previous messages to save space and reduce necessary scrolling, but that is maybe a further step.

@GretaD

GretaD commented Jul 27, 2020

Copy link
Copy Markdown
Contributor Author

@GretaD yes, doing it like Gmail sounds great! :) Also another good reference is Hey: https://www.youtube.com/watch?v=UCeYTysLyGI&t=19m45s

Ideal would be if we could also collapse any quoted messages or signatures from previous messages to save space and reduce necessary scrolling, but that is maybe a further step.

<3 thank you, i will let you know when its ready for a final review, so you dont lose time to check my fixups.

@GretaD GretaD force-pushed the feature/threading_list branch 3 times, most recently from 95b4290 to fd8a8cb Compare July 27, 2020 13:51
@GretaD

GretaD commented Jul 27, 2020

Copy link
Copy Markdown
Contributor Author

BUG

  • Fix Iframe for MessageHTMLBody

@GretaD GretaD added this to the v1.5 milestone Jul 28, 2020
@GretaD GretaD force-pushed the feature/threading_list branch 2 times, most recently from d769944 to 3534daf Compare July 29, 2020 15:07
@ChristophWurst

Copy link
Copy Markdown
Member

Ideal would be if we could also collapse any quoted messages or signatures from previous messages to save space and reduce necessary scrolling, but that is maybe a further step.

Yep, this is definitely a later step as it's not a trivial problem to solve. We either have to rewrite the original message in a way that the iframe displays with collapsible quotes or we need some JS inside the iframe. Both paths are rather complex and I would like to focus on the grouping and navigation between related messages first.

@ChristophWurst

This comment has been minimized.

@ChristophWurst

Copy link
Copy Markdown
Member

Rebased. Now this works with the latest changes from #3439, yay.

@ChristophWurst

Copy link
Copy Markdown
Member

Jumping between messages from the same thread works very nicely already :)

@ChristophWurst

Copy link
Copy Markdown
Member

Layout-wise we currently have

  • msg1
  • msg2
  • msg3 (currently active one, but still shown as link)
  • msg4
  • content of msg3

… if you open a message in the middle of a thread. But it should be

  • msg1
  • msg2
  • content of msg3
  • msg4

… like in gmail/hey. Does that make sense? not sure how well the messages newer than the current message will render when they are down below, but let's find out :)

@ChristophWurst ChristophWurst changed the title Add threading list Show previous and successive messages of the same thread Sep 1, 2020
@ChristophWurst

Copy link
Copy Markdown
Member

This is very basic but let's integrate and improve the design step by step 👍

Signed-off-by: GretaD <gretadoci@gmail.com>
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@GretaD GretaD merged commit 1ce0aae into master Sep 1, 2020
@GretaD GretaD deleted the feature/threading_list branch September 1, 2020 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants