Skip to content

Rework routing, data structures and naming ambiguities #3439

Merged
GretaD merged 1 commit into
masterfrom
techdept/routing-rework
Aug 25, 2020
Merged

Rework routing, data structures and naming ambiguities #3439
GretaD merged 1 commit into
masterfrom
techdept/routing-rework

Conversation

@ChristophWurst

@ChristophWurst ChristophWurst commented Aug 11, 2020

Copy link
Copy Markdown
Member

This changes a lot of things

  • Mailboxes are identified by their database ID (as opposed to account ID and name)
  • Messages are identified by their database ID (as opposed to account ID, mailbox name and message UID)
  • Routes are simplified and use the browser history API (as opposed to client-only anchor routes)
  • The Vuex store got a lot simpler, because the normalization is obsolete due to the naturally unique IDs
  • Naming inconsistency of maibox/folder finally resolved -> we call it "mailbox" in the code (as that is the proper name by the standards) and "folder" for the user (because @jancborchardt prefers that)

Required for deep links in #3433 and possibly for threading.

  • (accountId, folderId) to mailbox ID
  • Drafts handling (with db IDs)
  • Sync handling (with db IDs)

@ChristophWurst ChristophWurst added this to the v1.5 milestone Aug 11, 2020
@ChristophWurst ChristophWurst self-assigned this Aug 11, 2020
@ChristophWurst ChristophWurst changed the title Rework the routing Rework routing, data structures and naming ambiguities Aug 13, 2020
@ChristophWurst ChristophWurst requested a review from GretaD August 19, 2020 09:07
@ChristophWurst ChristophWurst force-pushed the techdept/routing-rework branch from 0d5b472 to 77b39a0 Compare August 24, 2020 15:47
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst force-pushed the techdept/routing-rework branch from 77b39a0 to 9498eba Compare August 24, 2020 18:22
@ChristophWurst ChristophWurst marked this pull request as ready for review August 25, 2020 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants