Add a unified search provider #3433
Merged
Merged
Conversation
This was referenced Aug 11, 2020
ChristophWurst
force-pushed
the
feature/unified-search
branch
from
1117c07 to
4445f2e
Compare
ChristophWurst
force-pushed
the
feature/unified-search
branch
from
4445f2e to
08cc114
Compare
3 tasks
ChristophWurst
force-pushed
the
feature/unified-search
branch
from
08cc114 to
49d7d48
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
feature/unified-search
branch
from
49d7d48 to
a68eace
Compare
ChristophWurst
requested review from
GretaD,
StCyr,
rullzer,
skjnldsv and
violoncelloCH
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
feature/unified-search
branch
from
a68eace to
cf8c482
Compare
skjnldsv
reviewed
Aug 25, 2020
| $qb->createNamedParameter('%' . $this->db->escapeLikeParameter($query->$query->getSubject()) . '%', IQueryBuilder::PARAM_STR), | ||
| IQueryBuilder::PARAM_STR | ||
| $qb->expr()->orX( | ||
| ...array_map(function (string $subject) use ($qb) { |
Member
There was a problem hiding this comment.
😱 You can do that in php too??
skjnldsv
approved these changes
Aug 25, 2020
ChristophWurst
commented
Aug 25, 2020
| /** | ||
| * We combine local flag and headers merge with UIDs that match the body search if necessary | ||
| * | ||
| * @todo find a way to search across all mailboxes efficiently without iterating over each of them and include IMAP results |
GretaD
approved these changes
Aug 25, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-ups
Proof that it works