Sieve

[kesselb]

Todo:

• Add Managesieve as dependency
• DB fields to store sieve configuration
• Provisioning support
• Account Form
• Text-Editor for current sieve script
• Custom Logger for ManageSieve (because Horde_Imap_Client_Base_Debug do not work)
• Migration to add sieveEnabled = false to existing provisioning configurations
• Unit-Test for SieveController
• Test upgrade from 1.8.0 (with and without provisioning)

Nice to have:

• Validation for sieve script (is done by managesieve itself)
• Detect sieve/managesieve via capabilities
• Move SieveController.updateAccount to service

CI:

Build fails because the sieve integration server uses self signed certificates.
We need horde/ManageSieve#1 or apply the patch on CI.

Screenshots:

[kesselb]

Did some testing today for the update path.

Test instance with 3 users and a provisioning configuration. In addition configured a normal email account. Migration added the new fields (to db and provisioning config).

Update gone through without issues. State after the update es expected (sieve disabled for all accounts).

[miaulalala]

Suggested change

	#sieve-text-area {
	font-size: 14px;
	line-height: 22px;
	font-family: monospace;
	}

[ChristophWurst]

we will evaluate the usage of a nicer editor with syntax highlighting anyway, so let's address this later

[miaulalala]

Suggested change

	if ($config->getSieveEnabled()) {
	$account->setSieveUser($config->buildSieveUser($user));
	$account->setSieveHost($config->getSieveHost());
	$account->setSievePort($config->getSievePort());
	$account->setSieveSslMode($config->getSieveSslMode());
	} else {
	$account->setSieveUser(null);
	$account->setSieveHost(null);
	$account->setSievePort(null);
	$account->setSieveSslMode(null);
	}
	return $account;
	}
	if ($config->getSieveEnabled()) {
	$account->setSieveUser($config->buildSieveUser($user));
	$account->setSieveHost($config->getSieveHost());
	$account->setSievePort($config->getSievePort());
	$account->setSieveSslMode($config->getSieveSslMode());
	return $account;
	}
	$account->setSieveUser(null);
	$account->setSieveHost(null);
	$account->setSievePort(null);
	$account->setSieveSslMode(null);
	return $account;
	}

No need to wait to return here, if the condition is fulfilled, we can safely return the set values.

[ChristophWurst]

yes and no 😉

I think this is one of those cases where the if and the else branch have equal importance. The early return would (to me) signal that it's some error condition or anything very specific.

I would keep the explicit if-else here.

But again, this formatting doesn't change any logic, nor does it make anything faster. I'm fine with either :)

[miaulalala]

It works fine, no issues.

[ChristophWurst]

Works very well!

[dumblob]

Looks really good and minimal to me. Well done! Thanks a lot.

Dumb question (I didn't apply this patch yet) - has this been tested with multi-account setups?

[ChristophWurst]

Dumb question (I didn't apply this patch yet) - has this been tested with multi-account setups?

Yes. There is a setting per account.