Refactor NoteFragments, category in ActionBar#299
Merged
Conversation
Member
|
@korelstar can you please resolve the remaining conflicts? |
korelstar
force-pushed
the
note-activity
branch
from
4b1504a to
cb1deb2
Compare
korelstar
changed the title
Member
Author
|
ready for review/merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete refactoring of
EditNoteActivity,NoteFragmentI,NoteEditFragmentandNotePreviewFragment. Please don't start big changes on these classes until this PR is finished.EditNoteActivity: management of fragments (start intended view/edit mode and save state) and calling from app and widgetBaseNoteFragment: handling of note (loading, saving), menu and ActionBar and respective actions on themNoteEditFragment: handling auto-saveNotePreviewFragment: just display the note