Categories in NavigationDrawer

[korelstar]

This work in ready for merge, now. Closes #165.

• introduce NavigationDrawer with hamburger icon
• some code improvements/refactoring in NotesListViewActivity
• move "settings" and "about" from menu to navigation
• show "current" and "starred" in navigation
• show every existent category in navigation
• app is started with selection "current" (same behavior like before)
• filter notes list in depdendeny of navigation selection
• show notes in alphabetical order if category is selected
• don't show starred notes above of not-starred notes (because there is the new selection "starred")
• highlight current selection in navigation
• set ActionBar title to indicate current category selection (?)
• add icons for each navigation entry
• show notes count for each navigation entry
• load category list in background thread
• refresh category list if notes list is refreshed
• only show first-level categories in navigation / show notes of all sub-categories in notes list
• show sub-category as header in notes list
• set category category of new note to the currently selected category, when clicking on the create note button
• keep current category selection when rotating device
• don't show category in list of notes items, if a category is selected (?)
• show sub-categories (second level) by clicking on the icon in the navigation (?)
• check (and fix?) compatibility to note selection for single note widget
• check (and fix?) indentation of changed files (4 spaces vs. tabs)
• replace "/" by " / " in category titles everywhere in the GUI (this makes reading of sub-categories easier)
• provide a drop-down list of existing categories in the change-category dialog
• don't update changed-time of the note when updating the category (since it's meta-data, same behavior when starring a note)

[stefan-niedermann]

Awesome!

[korelstar]

I'm done. Please test this, everybody! And please give feedback to design issues.

[korelstar]

Here are some impressions (screenshots):

Notes list (start activity)

Notes list with a category selected

Navigation drawer (only first-level categories)

Navigation drawer with open category (click on the "plus folder" icon to show second-level categories for that category)

[korelstar]

I've added some enhancements:

• replace "/" by " / " in category titles everywhere in the GUI (this makes reading of sub-categories easier)
• provide a drop-down list of existing categories in the change-category dialog
• don't update changed-time of the note when updating the category (since it's meta-data, same behavior when starring a note)

[dan0xii]

I really like the functionality and it's testing ok so far on my phone. The one thing I was confused by was the default view being "Recent" but the starred notes not being grouped at the top. I suppose I think of starred as pinned and expect to see them first before anything else--maybe this wouldn't be classified as "Recent" items but a different view.

[korelstar]

Yes, it's a little bit different than before. But now, it's more aligned to other Nextcloud apps: Typically, you have a separate navigation item for starred objects.

But we can discuss this point further. I'm happy to read more opinions on this.

[korelstar]

@stefan-niedermann What's you opinion on this? Do you plan to review or should I merge this by myself?

[stefan-niedermann]

I planned to review this and #298 this saturday :)

As far as i can see from the screenshots, it seems to be great :) This is worth a little candy for me, i will contact you after final merge.

[stefan-niedermann]

Really awesome work :) Thank you @korelstar

[stefan-niedermann]

Thanks, wanted to remove all possible Nextcloud/ownCloud-References long time ago...

[dan0xii]

Am I correct in thinking that I now can't get the same view that used to exist pre-category drawer, i.e. notes being sorted by starred and then modified?

[dan0xii]

Another comment on the "Recent" notes tab. As of v. 2.3.2 of the Nextcloud Notes app, notes are displayed by starred->modified, the way that the android app used to.

[korelstar]

Let's continue the discussion on the favorites sorting in #346 :-)