Drawer menu implementation#307
Conversation
|
Pinging @korelstar @stefan-niedermann for review / feedback :) |
|
Sorry, this month (and I think also the next one) I have no time for this project. But after that, I'll be back ;-) Nevertheless, I've noticed your PR and I thank you very much for your contribution. However, I'm very confused about it, since we've introduced the NavigationDrawer already in #275 (it was merged into |
|
@korelstar thanks for the feedback. I missed #275 and only saw #198. Looking at #275 it seems to me that one already implements anything which this PR would have added. So it can likely be closed. |
This PR is a new take (compared to #198) on implementing the drawer menu (basically what I implemented on the Nextcloud client and Nextcloud SMS client itself).
Due to my IDE setup this PR will also update the build tools used, the gradle wrapper and the Android gradle plugin version too. So this PR needs Android Studio 3.0.1 to work. If this is a problem than I can revert back the files that lead to this (their are not necessary for this PR but have been auto-updated by Android Studio 3.0.1).
This PR adds a Drawer Implementation to the main view of the app adding
Here are 2 screenshot of how it looks on Android 8 (and since it is implemented with the standard appCompat classes it also looks like this on older Android versions :)
Please let me know if anything needs to be changed and don't hesitate to ask any questions that might come up.
cc @jancborchardt @korelstar @stefan-niedermann 😀
Hope you like my work ❤️