Fix mtimes for share root#1678
Merged
Merged
Conversation
|
@icewind1991, thanks for your PR! By analyzing the history of the files in this pull request, we identified @owncloud-bot, @blizzz and @jmaciasportela to be potential reviewers. |
Member
|
@icewind1991 You haven't signed off ;) |
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
smb-stat-root
branch
from
1eef7fb to
85bd558
Compare
Member
Author
|
@LukasReschke @MorrisJobke please review |
Member
|
@icewind1991 do you have steps to tests? |
Member
|
@icewind1991 testing steps? |
Member
@icewind1991 Ping |
Member
|
ping 😉 |
Member
Author
Files that are hidden in smb should no longer show up, for the mtime part I'm not sure since that came from owncloud/core#25954 |
Member
|
@icewind1991 Can we move that to 12? I'd prefer to consider 11 closed for any non-critical merges. |
Member
|
I tested this by just adding an SMB mount and syncing against it. Didn't break so LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also known as "#1151, the good parts"
cc @LukasReschke