forward port smbfixes#25954
Merged
Merged
Conversation
|
@butonic, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blizzz, @icewind1991, @PVince81 and @Xenopathic to be potential reviewers |
butonic
force-pushed
the
master-smbfixes
branch
from
4096f5a to
ab55969
Compare
butonic
force-pushed
the
master-smbfixes
branch
from
ab55969 to
c213d6d
Compare
Contributor
Author
|
@jvillafanez @DeepDiver1975 @PVince81 jenkins is happy |
Member
|
Code looks good 👍 |
| * @author Thomas Müller <thomas.mueller@tmit.eu> | ||
| * @author Vincent Petry <pvince81@owncloud.com> | ||
| * | ||
| * @copyright Copyright (c) 2016, ownCloud GmbH. |
Member
There was a problem hiding this comment.
should be gmbh - but we will fix this with the license script
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
forward port smbfixes of #25817 to master
Related Issue
debugged at customer
Motivation and Context
Windows seems to set the hidden flag on shares of drives, eg. E: This PR fakes the visibility and forward ports the trace logging developed to find the root cause / reproduce the problem.
How Has This Been Tested?
At the customer, locally and with the testsuite. Although we should add a share that is set up as described above to automatically cover the use case.
Types of changes
Checklist: