Use clearer name setUpScenario#3559
Closed
phil-davis wants to merge 3 commits into
Closed
Conversation
|
@phil-davis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nickvergessen, @LukasReschke and @ChristophWurst to be potential reviewers. |
nickvergessen
approved these changes
Feb 21, 2017
ChristophWurst
added
4. to release
Contributor
Author
|
Matching change in ownCloud owncloud/core#27189 also |
Contributor
Author
|
CI drone pr failure: what is that all about? |
Member
|
Please see https://github.com/nextcloud/server#contribution-guidelines. We require all commits to this repository to be signed (using |
added 2 commits
February 21, 2017 19:34
Signed-off-by: Phil Davis <phil.davis@inf.org>
…nto setUpScenario
Contributor
Author
|
This is not going to work like this. Resubmitted as #3566 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #3558
The name tearUpScenario was confusing when I was looking at how some existing tests were set up. In English, "tear up" is what you do with a printed contract when you do not like it! It is a destructive thing.
Rename it to setUpScenario