Skip to content

Use clearer name setUpScenario#27189

Merged
PVince81 merged 1 commit into
masterfrom
setUpScenario
Feb 21, 2017
Merged

Use clearer name setUpScenario#27189
PVince81 merged 1 commit into
masterfrom
setUpScenario

Conversation

@phil-davis

Copy link
Copy Markdown
Contributor

Description

The name tearUpScenario was confusing when I was looking at how some existing tests were set up. In English, "tear up" is what you do with a printed contract when you do not like it! It is a destructive thing.

Rename it to setUpScenario

Related Issue

#27188

Motivation and Context

Reduce confusion for developers/users that are learning the test infrastructure.

How Has This Been Tested?

The automated tests should still run fine when I press "Create pull request" in a moment.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Improve code clarity

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mention-bot

Copy link
Copy Markdown

@phil-davis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @DeepDiver1975, @PVince81 and @SergioBertolinSG to be potential reviewers.

@PVince81 PVince81 added this to the 10.0 milestone Feb 21, 2017
@PVince81 PVince81 merged commit aecaebb into master Feb 21, 2017
@PVince81 PVince81 deleted the setUpScenario branch February 21, 2017 10:12
@lock

lock Bot commented Aug 3, 2019

Copy link
Copy Markdown

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Aug 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants