Use preDelete hook to delete encryption keys #3880
Closed
MorrisJobke wants to merge 1 commit into
Closed
Conversation
Because we sometimes need to mount the user's home before deleting encryption keys, this must happen in a preDelete hook because the postDelete is too late. In postDelete the user's home already doesn't exist any more and cannot be mounted.
MorrisJobke
added
3. to review
MorrisJobke
requested review from
icewind1991,
nickvergessen,
rullzer and
schiessle
March 16, 2017 23:30
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @nickvergessen and @rullzer to be potential reviewers. |
Member
Author
|
Succeeded by #3883 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we sometimes need to mount the user's home before deleting
encryption keys, this must happen in a preDelete hook because the
postDelete is too late. In postDelete the user's home already doesn't
exist any more and cannot be mounted.