Ignore exception when deleting keys of deleted user#3883
Merged
Conversation
MorrisJobke
added
3. to review
MorrisJobke
requested review from
LukasReschke,
blizzz,
icewind1991,
nickvergessen and
schiessle
March 16, 2017 23:59
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @schiessle, @nickvergessen and @LukasReschke to be potential reviewers. |
Whenever a user was deleted for encryption where the keys are stored in the home, we can ignore user existence exceptions because it means the keys are already gone. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
downstream-26968
branch
from
March 17, 2017 06:07
bc1efc5 to
aebb8c3
Compare
Codecov Report
@@ Coverage Diff @@
## master #3883 +/- ##
============================================
- Coverage 54.21% 54.21% -0.01%
- Complexity 21092 21093 +1
============================================
Files 1303 1303
Lines 80526 80527 +1
Branches 1270 1270
============================================
Hits 43657 43657
- Misses 36869 36870 +1
Continue to review full report at Codecov.
|
nickvergessen
approved these changes
Mar 17, 2017
blizzz
approved these changes
Mar 17, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whenever a user was deleted for encryption where the keys are stored in
the home, we can ignore user existence exceptions because it means the
keys are already gone.