Integration test check download without saving file locally#3894
Merged
Conversation
Use Guzzle stream mode to download the contents instead of using a temporary local file. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG, @nickvergessen and @rullzer to be potential reviewers. |
MorrisJobke
requested review from
LukasReschke,
icewind1991,
nickvergessen,
rullzer and
schiessle
Codecov Report
@@ Coverage Diff @@
## master #3894 +/- ##
=========================================
Coverage 54.21% 54.21%
Complexity 21092 21092
=========================================
Files 1303 1303
Lines 80526 80526
Branches 1270 1270
=========================================
Hits 43657 43657
Misses 36869 36869Continue to review full report at Codecov.
|
Member
|
Tests still pass 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Guzzle stream mode to download the contents instead of using a
temporary local file.