Integration test check download without saving file locally#27008
Conversation
|
@PVince81, thanks for your PR! By analyzing the history of the files in this pull request, we identified @SergioBertolinSG to be a potential reviewer. |
|
Here you are losing the check of the file mimetype, when the server is not working ok usually it returns a webpage and the mimetype fails html != plain. |
|
Ah, I missed that bit. But the mime type check really is only to make sure that the file contents is the same as on the server. |
|
Actually it's easier: check the mime type of the response. |
Use Guzzle stream mode to download the contents instead of using a temporary local file.
0a1787e to
788f20b
Compare
|
@SergioBertolinSG I've added back mime type detection, this time based on the buffer. Please re-check and merge if you agree. |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Description
Use Guzzle stream mode to download the contents instead of using a
temporary local file.
Related Issue
Fixes #27006
Motivation and Context
Makes it possible for all tests to pass on my env where I have different permissions (www-run, etc)
How Has This Been Tested?
Ran on my env, the test from the ticket passes now.
Screenshots (if appropriate):
Types of changes
Checklist:
@SergioBertolinSG please review