Server side checksum verification#4023
Closed
MorrisJobke wants to merge 4 commits into
Closed
Conversation
MorrisJobke
commented
Mar 23, 2017
MorrisJobke
commented
Member
- downstream of Server side checksum verification #26655 owncloud/core#27097
MorrisJobke
requested review from
LukasReschke,
blizzz,
icewind1991,
nickvergessen,
rullzer and
schiessle
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @nickvergessen and @schiessle to be potential reviewers. |
Member
Author
|
We maybe put also owncloud/core#27345 in this PR |
rullzer
reviewed
Mar 24, 2017
| public function getCapabilities() { | ||
| return [ | ||
| 'checksums' => [ | ||
| 'supportedTypes' => ['SHA1'], |
Member
There was a problem hiding this comment.
maybe we should also offer something else 😉
Member
|
Just to explain. This is not checksum verification as far as I can tell from a quick look. |
icewind1991
requested changes
Mar 24, 2017
icewind1991
left a comment
icewind1991
left a comment
Member
There was a problem hiding this comment.
Let me fix this up a bit before merging
icewind1991
force-pushed
the
downstream-27097
branch
from
31af733 to
773737b
Compare
Member
Author
Tests are still failing |
adding file_put_contents implementation to checksum wrapper #26655 fixing bug where stream was not defined #26655 fixing bug where wrapper could not write to memory stream#26655 fixing priority #26655 fixing broken indents adding class description #26655 Integration tests for checksuming #26655 - adding memory capped cache for paths - do not register checksum wrapper for #26655 no mimetype handling code #26655 Fixing failing testExpireOldFilesShared by puting it before testExpireOldFiles. If testExpireOldFiles runs before testExpireOldFilesShared, the second test fails randomly. #26655 Checksum only on write #26655 strong comparison Reverting accidentally commited testcode #26655 Fixing basic lock test fail #26655 Adding checksum download test #26655 Multiple checksums support + tests#26655 Files without checksum in oc_filecache get a checksum on first read #26655 Revert strpos fix #26655 Caching of file id, and various small fixes #26655 Added test about adding a file to local storage Checksum was not well calculated Don't wrap failed fopen in checksum wrapper Fix locking tests in ViewTest Checksums tests removed from webdav-feature Fixed wrong strpos condition Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
downstream-27097
branch
from
773737b to
6b0fc89
Compare
MorrisJobke
added
2. developing
Member
Author
|
@icewind1991 Could you have a look at the tests? |
Member
Author
Ping |
MorrisJobke
pushed a commit
that referenced
this pull request
Apr 27, 2017
* cleaner checksum check in test * cleanup checksum wrappers * fix error when trying to remove non existing entry from cache Signed-off-by: Robin Appelman <robin@icewind.nl>
MorrisJobke
added a commit
that referenced
this pull request
Apr 27, 2017
Closed
Member
Author
|
Continued in #4520 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.