Skip to content

Checksum verification#4520

Closed
nickvergessen wants to merge 41 commits into
masterfrom
downstream-27689
Closed

Checksum verification#4520
nickvergessen wants to merge 41 commits into
masterfrom
downstream-27689

Conversation

@nickvergessen

@nickvergessen nickvergessen commented Apr 26, 2017

Copy link
Copy Markdown
Member

Downstream 27689 + others

IljaN and others added 30 commits April 26, 2017 14:03
@IljaN @nickvergessen
Server side checksum verification #26655
6605874
@IljaN @nickvergessen
adding file_put_contents implementation to checksum wrapper #26655
87a3331
@IljaN @nickvergessen
fixing bug where stream was not defined #26655
cedc3d3
@IljaN @nickvergessen
fixing bug where wrapper could not write to memory stream#26655
b109f0b
@IljaN @nickvergessen
fixing priority #26655
9c95517
@IljaN @nickvergessen
fixing broken indents
8ed6854
@IljaN @nickvergessen
adding class description #26655
d126d10
@IljaN @nickvergessen
Integration tests for checksuming #26655
fbddc81
@IljaN @nickvergessen
- adding memory capped cache for paths
2cfc921 
- do not register checksum wrapper for #26655
@IljaN @nickvergessen
no mimetype handling code #26655
677b9f9
@IljaN @nickvergessen
Fixing failing testExpireOldFilesShared by puting it before testExpir…
a5da611 
…eOldFiles. If testExpireOldFiles runs before testExpireOldFilesShared, the second test fails randomly. #26655
@IljaN @nickvergessen
Checksum only on write #26655
866ddb2
@IljaN @nickvergessen
strong comparison
cb3a969
@IljaN @nickvergessen
Reverting accidentally commited testcode #26655
f03db14
@IljaN @nickvergessen
Fixing basic lock test fail #26655
16a8188
@IljaN @nickvergessen
#26655 Moved MoveFileIntoSharedFolderAsRecepient up because it has so…
af29732 
…me weird sideeffects if other tests are running before it, couldn`t find out the root cause, test runs ok in isolation.
@IljaN @nickvergessen
Adding checksum download test #26655
c17ca39
@IljaN @nickvergessen
Multiple checksums support + tests#26655
e43b50a
@IljaN @nickvergessen
#26655 eventual mimetype error fix
45e9d34
@IljaN @nickvergessen
Webdav returns only one checksum (SHA1)
f21e2fd
@IljaN @nickvergessen
Various smaller improvements, additional upload chunked with checksum…
981f4f3 
… test
@IljaN @nickvergessen
#26655 strpos bugfix
2ef9897
@IljaN @nickvergessen
Files without checksum in oc_filecache get a checksum on first read #…
b174da8 
…26655
@IljaN @nickvergessen
Revert strpos fix #26655
80cd139
@IljaN @nickvergessen
Caching of file id, and various small fixes #26655
cfdf25f
@IljaN @nickvergessen
Added test about adding a file to local storage
86ba432
@SergioBertolinSG @nickvergessen
Checksum was not well calculated
7b1f6d9
@nickvergessen
Don't wrap failed fopen in checksum wrapper
9932b41
@nickvergessen
Fix locking tests in ViewTest
9684891
@SergioBertolinSG @nickvergessen
Checksums tests removed from webdav-feature
5db5d60
@codecov

codecov Bot commented Apr 26, 2017 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (master@ba43a09). Click here to learn what that means.
The diff coverage is 81.87%.

@@            Coverage Diff            @@
##             master    #4520   +/-   ##
=========================================
  Coverage          ?   54.24%           
  Complexity        ?    21943           
=========================================
  Files             ?     1352           
  Lines             ?    84104           
  Branches          ?     1334           
=========================================
  Hits              ?    45621           
  Misses            ?    38483           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
apps/files/lib/Capabilities.php 0% <0%> (ø) 2 <0> (?)
apps/dav/lib/Connector/Sabre/FilesPlugin.php 79.62% <100%> (ø) 47 <0> (?)
lib/private/legacy/util.php 63.33% <100%> (ø) 218 <0> (?)
apps/dav/lib/Connector/Sabre/File.php 72.95% <74.28%> (ø) 101 <7> (?)
lib/private/Files/Stream/Checksum.php 77.35% <77.35%> (ø) 20 <20> (?)
lib/private/Files/Storage/Wrapper/Checksum.php 96.15% <96.15%> (ø) 19 <19> (?)

icewind1991 and others added 2 commits April 27, 2017 00:16
@icewind1991 @MorrisJobke
squashed commit from icewind1991 - see #4023
0f29b4c 
* cleaner checksum check in test
* cleanup checksum wrappers
* fix error when trying to remove non existing entry from cache

Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke
Diff to #4023
c7132a4 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke

MorrisJobke commented Apr 27, 2017

Copy link
Copy Markdown
Member

I cherry picked the fixed stuff from @icewind1991 from #4023 and the only diff that my PR and your PR had.

@icewind1991 @nickvergessen Please have a look at it if this still makes sense.

@MorrisJobke MorrisJobke mentioned this pull request Apr 27, 2017
Closed
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Apr 27, 2017
@MorrisJobke MorrisJobke requested a review from icewind1991 April 27, 2017 03:19
@nickvergessen

nickvergessen commented Apr 27, 2017

Copy link
Copy Markdown
Member Author

I have no idea, I just cherry-picked. Hopefully icewind can

@MorrisJobke

MorrisJobke commented Apr 29, 2017

Copy link
Copy Markdown
Member

@icewind1991 @rullzer we need your help here

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Apr 29, 2017
@MorrisJobke

MorrisJobke commented May 16, 2017

Copy link
Copy Markdown
Member

@icewind1991 @rullzer we need your help here

Ping

@MorrisJobke

MorrisJobke commented May 16, 2017

Copy link
Copy Markdown
Member

Also nothing for 12.

@MorrisJobke MorrisJobke removed this from the Nextcloud 12.0 milestone May 16, 2017
@rullzer rullzer added this to the Nextcloud 13 milestone May 23, 2017
@MorrisJobke

MorrisJobke commented Jun 19, 2017

Copy link
Copy Markdown
Member

@nickvergessen Any news here?

@nickvergessen

nickvergessen commented Jun 20, 2017

Copy link
Copy Markdown
Member Author

Well I only did the port, I have no idea whether we want this and how good it is and if it works for us...

@nickvergessen nickvergessen deleted the downstream-27689 branch February 16, 2018 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer Awaiting requested review from rullzer
@LukasReschke LukasReschke Awaiting requested review from LukasReschke
@icewind1991 icewind1991 Awaiting requested review from icewind1991

Assignees

@rullzer rullzer

@icewind1991 icewind1991

Labels

2. developing Work in progress

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

7 participants

@nickvergessen @mention-bot @MorrisJobke @rullzer @icewind1991 @IljaN @SergioBertolinSG