[stable12] Removed cast to integer in getSize#5925
Merged
Conversation
Fixes - Wrong or no sizes of files/folders nextcloud#5031 for 32-bit systems a direct cast to integer causes problems. Backport from nextcloud#5744 Signed-off-by: Sebastian Kostka <sebastian.kostka@gmail.com>
|
@derkostka, thanks for your PR! By analyzing the history of the files in this pull request, we identified @icewind1991, @nickvergessen and @LukasReschke to be potential reviewers. |
Contributor
Author
|
@LukasReschke @MorrisJobke, please review this backport |
derkostka
changed the title
derkostka
changed the title
Codecov Report
@@ Coverage Diff @@
## stable12 #5925 +/- ##
==============================================
- Coverage 54.08% 54.07% -0.02%
Complexity 22453 22453
==============================================
Files 1382 1382
Lines 85867 85867
Branches 1328 1328
==============================================
- Hits 46445 46436 -9
- Misses 39422 39431 +9
|
rullzer
approved these changes
Aug 1, 2017
MorrisJobke
approved these changes
Aug 1, 2017
MorrisJobke
added
4. to release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes - Wrong or no sizes of files/folders #5031 for 32-bit systems a direct cast to integer causes problems.
Backport from #5744
Signed-off-by: Sebastian Kostka sebastian.kostka@gmail.com