perf: Don't fetch all the trash items when deleting a single item#61906
Merged
Conversation
CarlSchwan
force-pushed
the
carl/trashitem-delete-optimization
branch
from
July 9, 2026 08:19
ffe88e1 to
f871721
Compare
CarlSchwan
marked this pull request as ready for review
July 9, 2026 08:19
CarlSchwan
requested review from
ArtificialOwl,
icewind1991,
leftybournes and
provokateurin
and removed request for
a team
July 9, 2026 08:19
provokateurin
requested changes
Jul 9, 2026
provokateurin
left a comment
provokateurin
left a comment
Member
There was a problem hiding this comment.
I'd prefer the reverse commit order, where you first move the code from getTrashFiles into a separate method and then use it instead of duplicating it first and then removing it.
CarlSchwan
force-pushed
the
carl/trashitem-delete-optimization
branch
from
July 9, 2026 09:11
5a2b87e to
96013b8
Compare
Member
Author
Done :) |
provokateurin
approved these changes
Jul 9, 2026
CarlSchwan
force-pushed
the
carl/trashitem-delete-optimization
branch
from
July 9, 2026 10:40
96013b8 to
acb2934
Compare
Altahrim
approved these changes
Jul 10, 2026
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
Only take one argument and instead call this with array map Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
AndyScherzinger
force-pushed
the
carl/trashitem-delete-optimization
branch
from
July 15, 2026 22:28
acb2934 to
b5dd899
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)