Skip to content

[stable33]: perf: Don't fetch all the trash items when deleting a single item#62179

Merged
AndyScherzinger merged 6 commits into
stable33from
carl/stable33/trashitem-delete-optimization
Jul 15, 2026
Merged

[stable33]: perf: Don't fetch all the trash items when deleting a single item#62179
AndyScherzinger merged 6 commits into
stable33from
carl/stable33/trashitem-delete-optimization

Conversation

@CarlSchwan

@CarlSchwan CarlSchwan commented Jul 15, 2026

Copy link
Copy Markdown
Member

Manual backport of #61906

Summary

TODO

  • ...

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@CarlSchwan
refactor: Extract buildFileInfo in a seperate method
a0424c7 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
perf: Don't fetch all the trash items when deleting a single item
a84b2d4 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
refactor: Extract and improve ITrashItem mapping to INode
2da796c 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
refactor: Remove some dead code from the trashbin Helper
e62ca8c 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
refactor(trashbin): Replace mapTrashItems by mapTrashItem
31dd442 
Only take one argument and instead call this with array map

Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan added this to the Nextcloud 33.0.7 milestone Jul 15, 2026
@CarlSchwan CarlSchwan self-assigned this Jul 15, 2026
@CarlSchwan
CarlSchwan requested a review from a team as a code owner July 15, 2026 13:08
@CarlSchwan CarlSchwan added the 3. to review Waiting for reviews label Jul 15, 2026
@CarlSchwan
CarlSchwan requested review from Altahrim and salmart-dev and removed request for a team July 15, 2026 13:08
cristianscheid
cristianscheid reviewed Jul 15, 2026
View reviewed changes
Comment thread apps/files_trashbin/lib/Trash/ITrashManager.php Outdated
cristianscheid
cristianscheid reviewed Jul 15, 2026
View reviewed changes
Comment thread apps/files_trashbin/lib/Trash/ITrashManager.php Outdated
@CarlSchwan
fix: Adjust API @SInCE version
c5a4137 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan
CarlSchwan force-pushed the carl/stable33/trashitem-delete-optimization branch from c7e4f67 to c5a4137 Compare July 15, 2026 14:02
@AndyScherzinger
AndyScherzinger merged commit 496a37a into stable33 Jul 15, 2026
173 of 176 checks passed
@AndyScherzinger
AndyScherzinger deleted the carl/stable33/trashitem-delete-optimization branch July 15, 2026 22:26
@nextcloud-bot nextcloud-bot mentioned this pull request Jul 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes
@cristianscheid cristianscheid cristianscheid approved these changes
@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/server-backend
@come-nc come-nc Awaiting requested review from come-nc come-nc is a code owner automatically assigned from nextcloud/server-backend

Assignees

@CarlSchwan CarlSchwan

Labels

3. to review Waiting for reviews performance 🚀

Projects

None yet

Milestone

Nextcloud 33.0.7

Development

Successfully merging this pull request may close these issues.

3 participants

@CarlSchwan @AndyScherzinger @cristianscheid