Skip to content

TwoFactorMiddleware should forward Exception#844

Merged
LukasReschke merged 1 commit into
masterfrom
twofactor_mw_excep
Aug 12, 2016
Merged

TwoFactorMiddleware should forward Exception#844
LukasReschke merged 1 commit into
masterfrom
twofactor_mw_excep

Conversation

@rullzer

@rullzer rullzer commented Aug 12, 2016

Copy link
Copy Markdown
Member

Middleware should rethrow the exception if it can't handle it.

CC: @BernhardPosselt @MorrisJobke @LukasReschke @ChristophWurst

@rullzer rullzer added the 3. to review Waiting for reviews label Aug 12, 2016
@rullzer rullzer added this to the Nextcloud 11.0 milestone Aug 12, 2016
@mention-bot

Copy link
Copy Markdown

@rullzer, thanks for your PR! By analyzing the annotation information on this pull request, we identified @ChristophWurst and @nickvergessen to be potential reviewers

@MorrisJobke

Copy link
Copy Markdown
Member

👍

@LukasReschke

Copy link
Copy Markdown
Member

LGTM

@LukasReschke LukasReschke merged commit 11e089f into master Aug 12, 2016
@LukasReschke LukasReschke deleted the twofactor_mw_excep branch August 12, 2016 18:15
GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this pull request Aug 30, 2016
TwoFactorMiddleware should forward Exception
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants