Move Provisioning API to the AppFramework#846
Merged
Conversation
rullzer
force-pushed
the
provisioning_api_ocs
branch
3 times, most recently
from
4e70c62 to
da64baa
Compare
rullzer
added
3. to review
Member
Author
|
Wheehee intergration tests are happy! Review time: @LukasReschke @MorrisJobke @nickvergessen @schiessle @icewind1991 |
| * | ||
| * @param array $parameters | ||
| * @return \OC\OCS\Result | ||
| * @NoAdminRequired |
Member
There was a problem hiding this comment.
Is there any middleware in place to require at least subadmin rights?
Member
There was a problem hiding this comment.
This is required to be able to catch the NotLoggedIn exceptions etc in the OCSMiddleware and convert them to proper OCS Responses.
* Always set 401 (v1.php and v2.php) * Set proper error codes for v2.php * Proper OCS output on unhandled exceptions
The provisioning API has 3 access levels: * Admin * SubAdmin * User This middleware adds a check for the SubAdmin part.
* Take advantage of the AppFramework * Fix tests
* Set OCS-APIREQUEST: true * PUT requires a body
rullzer
force-pushed
the
provisioning_api_ocs
branch
from
da64baa to
7754281
Compare
Member
|
LGTM |
Member
|
👍 |
GitHubUser4234
pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
Move Provisioning API to the AppFramework
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires: #844 and #845
Lets see what CI tells us