Backport all the things - #1044
Merged
Merged
Conversation
No functional changes yet, but this will allow later to use the standalone signaling backend to notify clients about new chat messages without having to poll (see #624). Signed-off-by: Joachim Bauch <bauch@struktur.de>
This removes the long-polling against the PHP backend and instead sends an event to all users in a room through the standalone signaling server to notify that new chat messages exist. Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
- sendRoomMessage - requestOffer - sendOffer Signed-off-by: Joachim Bauch <bauch@struktur.de>
With an MCU, each client publishes only once (to the MCU) and viewers subscribe the streams from the MCU. This means that for subscribing, the MCU always has to send the "Offer" message which requires some changes in the workflow. Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
With the MCU, a newly subscribed stream might not get the "audioOn"/"videoOn" messages as they are only sent when a user starts publishing. Instead wait for initial data and trigger events locally. Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
…icipants. The nick name below the avatar is distributed through the DataChannel of the PeerConnection and only sent once during establishment. For the MCU case, the sending PeerConnection is created once and then never changed when more participants join. For this, we periodically send the nick to all other participants through the sending PeerConnection. Signed-off-by: Joachim Bauch <bauch@struktur.de>
…atar. Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
nickvergessen
added
3. to review
bug
design
enhancement
feature: chat 💬
Member
|
I think you missed #890 in the description, the commits are present here. |
Member
Author
|
Tested chatting, calling and screensharing, all still working without the external signaling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #887
Backport #398
Backport #890
Backport #990
Backport #977