MCU integration - #398
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
=========================================
Coverage ? 10.32%
Complexity ? 394
=========================================
Files ? 23
Lines ? 1975
Branches ? 0
=========================================
Hits ? 204
Misses ? 1771
Partials ? 0
Continue to review full report at Codecov.
|
fancycode
force-pushed
the
standalone-signaling
branch
2 times, most recently
from
September 8, 2017 14:54
7e88cb8 to
d5e10f4
Compare
fancycode
force-pushed
the
mcu-integration
branch
from
September 8, 2017 14:56
e02c680 to
ea73d31
Compare
nickvergessen
force-pushed
the
standalone-signaling
branch
2 times, most recently
from
October 11, 2017 15:28
3ffdbde to
143a557
Compare
fancycode
force-pushed
the
standalone-signaling
branch
2 times, most recently
from
November 2, 2017 10:24
0b285f6 to
6d13722
Compare
fancycode
force-pushed
the
mcu-integration
branch
from
November 2, 2017 10:57
ea73d31 to
fdd0b75
Compare
fancycode
force-pushed
the
mcu-integration
branch
from
February 1, 2018 14:13
9d56bf1 to
1f168e8
Compare
nickvergessen
modified the milestones:
3.1 (Nextcloud 13.0.0/1),
3.2 (Nextcloud 13.0.2)
fancycode
force-pushed
the
mcu-integration
branch
from
April 30, 2018 14:36
e0c206e to
8703c3c
Compare
- sendRoomMessage - requestOffer - sendOffer Signed-off-by: Joachim Bauch <bauch@struktur.de>
With an MCU, each client publishes only once (to the MCU) and viewers subscribe the streams from the MCU. This means that for subscribing, the MCU always has to send the "Offer" message which requires some changes in the workflow. Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
With the MCU, a newly subscribed stream might not get the "audioOn"/"videoOn" messages as they are only sent when a user starts publishing. Instead wait for initial data and trigger events locally. Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
Signed-off-by: Joachim Bauch <bauch@struktur.de>
fancycode
force-pushed
the
mcu-integration
branch
from
June 19, 2018 12:18
8703c3c to
db5861e
Compare
Signed-off-by: Joachim Bauch <bauch@struktur.de>
…icipants. The nick name below the avatar is distributed through the DataChannel of the PeerConnection and only sent once during establishment. For the MCU case, the sending PeerConnection is created once and then never changed when more participants join. For this, we periodically send the nick to all other participants through the sending PeerConnection. Signed-off-by: Joachim Bauch <bauch@struktur.de>
fancycode
force-pushed
the
mcu-integration
branch
from
June 22, 2018 12:02
8f340e5 to
d726204
Compare
…atar. Signed-off-by: Joachim Bauch <bauch@struktur.de>
fancycode
force-pushed
the
mcu-integration
branch
from
June 22, 2018 13:59
52d5e33 to
18957e6
Compare
Ivansss
approved these changes
Jun 22, 2018
Member
|
@Ivansss no backport? |
This was referenced Jul 12, 2018
marcoambrosini
pushed a commit
that referenced
this pull request
Oct 9, 2019
Fix actions menu grey focus colour
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is work-in-progress to support using an MCU.
With an MCU, each client publishes only once (to the MCU) and viewers subscribe the streams from the MCU. This means that for subscribing, the MCU always has to send the "Offer" message which requires some changes in the workflow.