Skip to content

fix: Rewrite admin js without jQuery - #59

Merged
blizzz merged 1 commit into
nextcloud:mainfrom
RobertSmits:main
Jul 23, 2026
Merged

fix: Rewrite admin js without jQuery#59
blizzz merged 1 commit into
nextcloud:mainfrom
RobertSmits:main

Conversation

@RobertSmits

Copy link
Copy Markdown
Contributor

Replace all jQuery calls with vanilla JavaScript, as Nextcloud 34 has no support for it.
Fixes #58

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@LePiegro

LePiegro commented Jun 26, 2026

Copy link
Copy Markdown

Any news on this? We really need it!

@RobertSmits seems like your commit was not signed off, maybe they are waiting on that?

Signed-off-by: Robert Smits <robertsmits@hotmail.be>
@github-actions

Copy link
Copy Markdown

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@LePiegro

Copy link
Copy Markdown

@juliusknorr This fixes jQuery removal for NC 34 (#58) and is blocking us. The commit is signed off (2716a7a) and CI is green — could you review and merge?

@branddavid

Copy link
Copy Markdown

Hi, When do you think the app will be compatible and available in the Store?

@Netzarea

Netzarea commented Jul 3, 2026

Copy link
Copy Markdown

We are also waiting for the update so that we can finally update our customers instances that use this plugin to Nextcloud 34. When can we expect it to be compatible?

@user8446

user8446 commented Jul 6, 2026

Copy link
Copy Markdown

Please review and merge... upgrading to 34 broke a lot of things, thank you!

@arnowelzel

arnowelzel commented Jul 12, 2026

Copy link
Copy Markdown

I can confirm that this patch works for Nextcloud 34. If you don't want to wait, you can force install Custom CSS and then replace apps/theming_customcss/js/settings-admin.js with the patched version from this pull request:

https://raw.githubusercontent.com/RobertSmits/theming_customcss/2716a7ae0060cce34f9617165e6bdbaff941d588/js/settings-admin.js

@arnowelzel arnowelzel mentioned this pull request Jul 12, 2026
@blizzz
blizzz merged commit 63f8a38 into nextcloud:main Jul 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support NextCloud 34

7 participants