nmc/5903-favorites-rename-option-missing#492
Merged
Merged
Conversation
The core files app hides "Rename" for every item in the Favorites view because its enabled() check requires the real parent folder to have CREATE permission. Favorites is a flattened list aggregating items from many different folders, so no single real parent is resolvable, and the check always fails there. Patch the rename action's enabled() at runtime, scoped to the favorites view only, to fall back to the node's own DELETE + UPDATE permission bits instead of the parent folder's permissions. All other views keep the original, unmodified behavior.
memurats
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The core files app hides "Rename" for every item in the Favorites view because its enabled() check requires the real parent folder to have CREATE permission. Favorites is a flattened list aggregating items from many different folders, so no single real parent is resolvable, and the check always fails there.
Patch the rename action's enabled() at runtime, scoped to the favorites view only, to fall back to the node's own DELETE + UPDATE permission bits instead of the parent folder's permissions. All other views keep the original, unmodified behavior.