Skip to content

nmc/5903-favorites-rename-option-missing #492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
memurats merged 1 commit into from
Jul 23, 2026
Merged

nmc/5903-favorites-rename-option-missing #492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/nmcfiles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,25 @@ registerFileAction(fileAction)

const FileActions = getFileActions()

const renameAction = FileActions.find(action => action.id === 'rename')

if (renameAction?.enabled) {
const originalEnabled = renameAction.enabled

// Relies on `_action` being a plain field on FileAction (@nextcloud/files
// internal detail) - re-verify on @nextcloud/files upgrades.
;(renameAction as unknown as { _action: { enabled: typeof originalEnabled } })._action.enabled = (nodes: Node[], view: View) => {
if (view.id !== 'favorites') {
return originalEnabled(nodes, view)
}

return nodes.every(node =>
Boolean(node.permissions & Permission.DELETE)
&& Boolean(node.permissions & Permission.UPDATE),
)
}
}

const sharingStatusAction = FileActions.find(action => action.id === 'sharing-status')

if (sharingStatusAction) {
Expand Down
Loading