Skip to content

feat(store-devtools): use different action when recomputing state history#1353

Merged
brandonroberts merged 3 commits intongrx:masterfrom
tja4472:issue-1255
Oct 16, 2018
Merged

feat(store-devtools): use different action when recomputing state history#1353
brandonroberts merged 3 commits intongrx:masterfrom
tja4472:issue-1255

Conversation

@tja4472
Copy link
Contributor

@tja4472 tja4472 commented Oct 2, 2018

state history

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1255

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@coveralls
Copy link

coveralls commented Oct 2, 2018

Coverage Status

Coverage increased (+0.006%) to 88.405% when pulling 6daadad on tja4472:issue-1255 into 41a0d45 on ngrx:master.

computedStates = computedStates.map(cmp => ({
...cmp,
state: reducer(cmp.state, liftedAction),
state: reducer(cmp.state, RECOMPUTE_STATE_ACTION),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test case.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @tja4472

@brandonroberts brandonroberts merged commit 1448a0e into ngrx:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants