Skip to content

feat(store-devtools): use different action when recomputing state history #1353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandonroberts merged 3 commits into from
Oct 16, 2018
Merged

feat(store-devtools): use different action when recomputing state history #1353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
420e1f5
feat(store-devtools): use different action when recomputing
tja4472 Oct 2, 2018
0520680
correct spelling
tja4472 Oct 3, 2018
6daadad
add test
tja4472 Oct 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions modules/store-devtools/spec/store.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ import {
} from '../';
import { IS_EXTENSION_OR_MONITOR_PRESENT } from '../src/instrument';
import { PerformAction } from '../src/actions';
import { RECOMPUTE_STATE } from '../src/reducer';

const counter = jasmine
.createSpy('counter')
Expand Down Expand Up @@ -126,6 +127,20 @@ function createStore<T>(
}

describe('Store Devtools', () => {
describe('reducer', () => {
it('should call @ngrx/devtools/recompute-state action', () => {
const fixture = createStore(doubleCounter);
counter.calls.reset();
fixture.replaceReducer(counter);

const allArgs = counter.calls.allArgs();
expect(allArgs.length).toEqual(3);
expect(allArgs[0][1].type).toEqual(UPDATE);
expect(allArgs[1][1].type).toEqual(RECOMPUTE_STATE);
expect(allArgs[2][1].type).toEqual(RECOMPUTE_STATE);
});
});

describe('Instrumentation', () => {
let fixture: Fixture<number>;
let store: Store<number>;
Expand Down
5 changes: 4 additions & 1 deletion modules/store-devtools/src/reducer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ export type Actions = DevtoolsActions.All | CoreActions;

export const INIT_ACTION = { type: INIT };

export const RECOMPUTE_STATE = '@ngrx/devtools/recompute-state' as '@ngrx/devtools/recompute-state';
export const RECOMPUTE_STATE_ACTION = { type: RECOMPUTE_STATE };

export interface ComputedState {
state: any;
error: any;
Expand Down Expand Up @@ -501,7 +504,7 @@ export function liftReducerWith(
// Recompute state history with latest reducer and update action
computedStates = computedStates.map(cmp => ({
...cmp,
state: reducer(cmp.state, liftedAction),
state: reducer(cmp.state, RECOMPUTE_STATE_ACTION),
Copy link
Member

@timdeschryver timdeschryver Oct 2, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a test case.

}));

currentStateIndex = stagedActionIds.length - 1;
Expand Down