fix: avoid quoting cflag name and parameter with space separator#223
Merged
Conversation
legendecas
marked this pull request as ready for review
March 1, 2024 07:21
Member
Author
|
@nodejs/gyp I'd appreciate it if this could have a review, thank you! |
cclauss
requested changes
Mar 7, 2024
cclauss
left a comment
cclauss
left a comment
Contributor
There was a problem hiding this comment.
Please consider adding tests that fail without these changes but pass with these changes so that we can avoid future regressions.
cclauss
approved these changes
Mar 7, 2024
cclauss
left a comment
cclauss
left a comment
Contributor
There was a problem hiding this comment.
Nice!
Perhaps create a DRAFT PR with only the test changes to prove that the tests fail on the unmodified code
Member
Author
|
Sure, #224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: nodejs/node-gyp#2858
Avoid quoting
-arch arm64in generatedcompile_commands.jsonasc++ "-arch arm64".