Skip to content

chore: update Ruff to 0.3.1 - #226

Merged
cclauss merged 1 commit into
mainfrom
fix-ruff
Mar 8, 2024
Merged

chore: update Ruff to 0.3.1#226
cclauss merged 1 commit into
mainfrom
fix-ruff

Conversation

@targos

@targos targos commented Mar 7, 2024

Copy link
Copy Markdown
Member
- Fix new UP032 errors
- Fix deprecated Ruff config structure

BEGIN_COMMIT_OVERRIDE
fix: update Ruff to 0.3.1
END_COMMIT_OVERRIDE

@targos
targos requested a review from cclauss March 7, 2024 09:04

@legendecas legendecas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we pin ruff version as well?

@legendecas

Copy link
Copy Markdown
Member

FWIW, I pinned ruff to v0.3.0 in #223

- Fix new UP032 errors
- Fix deprecated Ruff config structure
@targos targos changed the title chore: fix new UP032 Ruff error and Ruff config chore: update Ruff to 0.3.1 Mar 7, 2024
@targos

targos commented Mar 7, 2024

Copy link
Copy Markdown
Member Author

Ok, I changed this to a Ruff update.

@cclauss

cclauss commented Mar 8, 2024

Copy link
Copy Markdown
Contributor

My preference is that we do not pin ruff because it is still in a state of flux and fixing Python code incrementally in a JavaScript codebase ensures that the squeaky wheel gets the grease. If we silence ruff then we will build a backlog of diverse changes that will be difficult to implement and get reviewed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants