feat: convert all internal functions to async/await#2924
Merged
Conversation
lukekarrys
force-pushed
the
lk/check-engines
branch
from
October 28, 2023 00:13
f4c5eaf to
051114e
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
from
October 28, 2023 00:29
de2c1cd to
051114e
Compare
lukekarrys
force-pushed
the
lk/check-engines
branch
from
October 28, 2023 00:33
ddb6020 to
7cba0db
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
4 times, most recently
from
October 28, 2023 03:12
56e7357 to
210543a
Compare
lukekarrys
force-pushed
the
lk/check-engines
branch
from
October 28, 2023 03:23
7cba0db to
ed3a910
Compare
lukekarrys
marked this pull request as draft
October 28, 2023 03:51
lukekarrys
force-pushed
the
lk/async-all
branch
from
October 28, 2023 03:53
210543a to
179dbdd
Compare
lukekarrys
marked this pull request as ready for review
October 28, 2023 04:19
Contributor
|
Not working so great on Windows.
~ |
lukekarrys
force-pushed
the
lk/async-all
branch
2 times, most recently
from
October 28, 2023 05:19
f9c558e to
1c7552e
Compare
Member
Author
|
Missed an |
BREAKING CHANGE: All internal functions have been coverted to return promises and no longer accept callbacks. This is not a breaking change for users but may be breaking to consumers of `node-gyp` if you are requiring internal functions directly.
lukekarrys
force-pushed
the
lk/async-all
branch
from
October 28, 2023 06:04
1c7552e to
8531963
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: All internal functions have been coverted to return
promises and no longer accept callbacks. This is not a breaking change
for users but may be breaking to consumers of
node-gypif you arerequiring internal functions directly.