feat: convert internal classes from util.inherits to classes#2925
Merged
Conversation
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
from
October 27, 2023 23:43
ce5e741 to
0a3e2e0
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
from
October 28, 2023 00:29
de2c1cd to
051114e
Compare
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
from
October 28, 2023 00:29
0a3e2e0 to
145e56a
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
from
October 28, 2023 00:33
051114e to
0501ace
Compare
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
2 times, most recently
from
October 28, 2023 01:34
e306967 to
614c26c
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
3 times, most recently
from
October 28, 2023 03:12
56e7357 to
210543a
Compare
lukekarrys
marked this pull request as draft
October 28, 2023 03:52
lukekarrys
force-pushed
the
lk/async-all
branch
from
October 28, 2023 03:53
210543a to
179dbdd
Compare
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
2 times, most recently
from
October 28, 2023 03:55
e842fd3 to
0a67958
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
2 times, most recently
from
October 28, 2023 05:19
f9c558e to
1c7552e
Compare
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
from
October 28, 2023 05:30
0a67958 to
472c33b
Compare
lukekarrys
force-pushed
the
lk/async-all
branch
from
October 28, 2023 06:04
1c7552e to
8531963
Compare
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
from
October 28, 2023 06:35
472c33b to
32a7787
Compare
lukekarrys
marked this pull request as ready for review
October 28, 2023 06:54
BREAKING CHANGE: the `Gyp` class exported is now created using ECMAScript classes and therefore might have small differences to classes that were previously created with `util.inherits`.
lukekarrys
force-pushed
the
lk/use-es6-classes
branch
from
October 28, 2023 16:01
32a7787 to
faa174b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This PR is stacked on #2924
BREAKING CHANGE: the
Gypclass exported is now created usingECMAScript classes and therefore might have small differences to classes
that were previously created with
util.inherits.