repl: hide top-level await feature behind a flag#19604
Closed
TimothyGu wants to merge 5 commits intonodejs:masterfrom
Closed
repl: hide top-level await feature behind a flag#19604TimothyGu wants to merge 5 commits intonodejs:masterfrom
TimothyGu wants to merge 5 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
Contributor
|
Should this be documented? |
Member
Author
devsnek
approved these changes
Mar 29, 2018
doc/api/repl.md
Outdated
Contributor
There was a problem hiding this comment.
Nit: maybe const timeout = and const old = to not emphasize sloppy mode?
TimothyGu
force-pushed
the
repl-await-flag
branch
from
e4a8224 to
ce1f2d5
Compare
Member
Author
Member
Author
|
I'll be landing this in a few days. |
TimothyGu
added a commit
that referenced
this pull request
Apr 18, 2018
PR-URL: #19604 Refs: #17807 Refs: #15566 (comment) Reviewed-By: Gus Caplan <me@gus.host>
Member
Author
Contributor
|
@TimothyGu It seems the flag also should be mentioned in |
Member
|
Since this is semver-patch it will definitely make it in to 10.0.0 |
Member
Author
|
@vsemozhetbyt See #20133. |
3 tasks
Contributor
|
This should be backported with #20133 |
TimothyGu
added a commit
that referenced
this pull request
Apr 18, 2018
PR-URL: #20133 Fixes: #19604 (comment) Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2018
PR-URL: #19604 Refs: #17807 Refs: #15566 (comment) Reviewed-By: Gus Caplan <me@gus.host>
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2018
PR-URL: #20133 Fixes: #19604 (comment) Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs: #17807
Refs: #15566 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes