doc: fully document --experimental-repl-await#20133
Closed
TimothyGu wants to merge 1 commit intonodejs:masterfrom
Closed
doc: fully document --experimental-repl-await#20133TimothyGu wants to merge 1 commit intonodejs:masterfrom
TimothyGu wants to merge 1 commit intonodejs:masterfrom
Conversation
3 tasks
richardlau
approved these changes
Apr 18, 2018
TimothyGu
added
the
fast-track
Member
Author
|
I'd like to fast track this. Please 👍-react if you agree! |
vsemozhetbyt
approved these changes
Apr 18, 2018
Contributor
vsemozhetbyt
added
the
author ready
Contributor
|
This should be backported with #19604 |
devsnek
approved these changes
Apr 18, 2018
ryzokuken
approved these changes
Apr 18, 2018
trivikr
approved these changes
Apr 18, 2018
jasnell
approved these changes
Apr 18, 2018
Member
Author
|
Landed in ceab78f. |
TimothyGu
added a commit
that referenced
this pull request
Apr 18, 2018
PR-URL: #20133 Fixes: #19604 (comment) Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 19, 2018
PR-URL: #20133 Fixes: #19604 (comment) Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #19604 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes