build: do not run benchmark tests on 'make test'#34434
Merged
Trott merged 8 commits intonodejs:masterfrom Jul 22, 2020
Merged
Conversation
nodejs-github-bot
added
the
build
Member
Author
bnoordhuis
approved these changes
Jul 20, 2020
addaleax
approved these changes
Jul 20, 2020
Trott
added
the
author ready
Collaborator
richardlau
approved these changes
Jul 20, 2020
Makefile
Outdated
Comment on lines
+301
to
+302
Member
There was a problem hiding this comment.
FWIW the reason we split tests into CI_JS_SUITES and CI_NATIVE_SUITES was that to accommodate the arm-fanned setup we split the tests into test-ci-native (requires a build toolchain set up to build the native addons) and test-ci-js (which "should not use a native compiler at all" (see comment in Makefile)).
For testing outside of the CI we don't have the same split in Makefile test targets, so you could optionally have a single make variable instead of two.
lpinca
approved these changes
Jul 20, 2020
10 tasks
Trott
removed
the
author ready
5 tasks
PR-URL: nodejs#34420 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/32468/ This passed. |
PR-URL: nodejs#34048 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fixes: nodejs#34242 PR-URL: nodejs#34417 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Otherwise the build would fail with `./configure --experimental-quic --ninja` as the list of per-Environment values would not match and the code cache builder would not generate code cache for the quic JS sources. This is more or less a band-aid - a proper fix would be to aggregate these flags into something that can be included by all these different binary targets. See nodejs#31074. PR-URL: nodejs#34454 Fixes: nodejs#34435 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
jasnell
approved these changes
Jul 22, 2020
This prevents accidental resource leaks when terminating or exiting Worker that own FDs opened through `fs.open()`. Refs: nodejs#34303 PR-URL: nodejs#34394 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
The "Labels" section of doc/guides/onboarding-extras.md was missing a reference to the `author-ready` label. This commit adds a description similar to the definition found in doc/guides/collaborator-guide.md with the goal of making it easier for new contributors to find labels info all in one place. PR-URL: nodejs#34381 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Notable changes: deps: * upgrade npm to 6.14.6 (claudiahdz) [nodejs#34246](nodejs#34246) * update node-inspect to v2.0.0 (Jan Krems) [nodejs#33447](nodejs#33447) * uvwasi: cherry-pick 9e75217 (Colin Ihrig) [nodejs#33521](nodejs#33521) PR-URL: nodejs#34343
Fixes: nodejs#34427 PR-URL: nodejs#34434 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
Author
|
Landed in 3caa2e2 |
This was referenced Jul 23, 2020
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like we've been running benchmark tests locally with
make test. Whoops. Let's not do that.Fixes: #34427
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes